Skip to content

fix(md): give islands the page frontmatter when they hydrate - #476

Merged
Brooooooklyn merged 1 commit into
mainfrom
fix/island-frontmatter
Oct 18, 2026
Merged

Brooooooklyn merged 1 commit into
mainfrom
fix/island-frontmatter

Conversation

@Brooooooklyn

Copy link
Copy Markdown
Member

Follow-up to #475.

Since #475, an island on a Markdown page sees the page frontmatter through useFrontmatter() during server rendering, but {} in the browser. React, Svelte and Vue then report a hydration mismatch and re-render the island with {}. Vue islands had the same gap before #475.

server:   island renders useFrontmatter().title → "Hello"
browser:  island hydrates as its own root, no page context → {} → mismatch, shows "undefined"

Behavior

useFrontmatter() now returns the page's frontmatter everywhere on a Markdown page: layouts, the page, and islands, both on the server and in the browser.

  • A page that renders at least one island and has frontmatter includes it once: <script type="application/json" id="__void_frontmatter">. Pages without islands or without frontmatter send nothing new.
  • initIslands reads it and passes it to each adapter's island hydration, which provides it the same way the server does: React and Solid FrontmatterContext, the Svelte hydrate() context, Vue provide.
  • React and Solid load @void/react / @void/solid for this only when the page has frontmatter.
  • The Markdown guide now says islands can read it, and that frontmatter on pages with islands is visible in the HTML.

Why send it, instead of giving islands {}

Astro, îles and Fresh islands get only their props. Here, though, useFrontmatter() already works in layouts and pages. If islands silently got {}, users would fall into the same trap as #451. Frontmatter is already public through @void/md/pages, and the cost is one small JSON script on pages with islands.

Tests

  • A browser test per adapter (md-layout-frontmatter.test.ts for React, Solid and Svelte, and the new md-island-frontmatter.test.ts for Vue) uses a shared helper, test/island-page-browser.ts. An island layout loads an island that prints useFrontmatter().title. Each test checks the JSON script is in the server HTML, then that the island still shows the title after hydration with no hydration warning.
  • Mutation checks: removing the browser-side provider for any one adapter makes its test show undefined. Removing the server script fails all four.
  • The fix(md): let layouts read the page frontmatter with React, Solid and Svelte #475 layout tests now also check that a page without islands gets no frontmatter script.
  • islandFrontmatterScript escapes </script> inside frontmatter values (deferred-xss.test.ts).
  • Run locally against the installed Chrome, because the Playwright Chromium download is blocked here. The existing react-island-hydration test still passes. Unit tests for void, md and the four adapters, lint, format and typecheck all pass.

🤖 Generated with Claude Code

Since #475, an island on a Markdown page saw the page frontmatter
through `useFrontmatter()` during server rendering but `{}` in the
browser, so frameworks reported a hydration mismatch and re-rendered it.

A page that renders islands now includes its frontmatter once as a JSON
script. `initIslands` reads it and passes it to each adapter's island
hydration, which provides it the same way the server renderer does
(React and Solid context, Svelte hydrate context, Vue provide).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T09:48:08.223696Z 2bc7aa8 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@Brooooooklyn

Copy link
Copy Markdown
Member Author

@codex review

@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview URL: https://fix-island-frontmatter-void-cloud.voidzero-docs.workers.dev (commit 2bc7aa8)

This URL reflects your latest Preview deployment

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Success ✅
  • Deployment: Success ✅

View logs ↗
https://302ce511-void-cloud.voidzero-docs.workers.dev 2bc7aa8 2026-10-18T09:45:58.032Z Visit the dashboard ↗

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 2bc7aa8925

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Brooooooklyn
Brooooooklyn merged commit 9ed64ba into main Oct 18, 2026
20 checks passed
@Brooooooklyn
Brooooooklyn deleted the fix/island-frontmatter branch October 18, 2026 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant