Repository navigation
Conversation
rdlabo
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #480
I'd love to ship apps built with Void as iOS and Android apps using Capacitor. Supporting
capacitor://navigation would open that door! I've been testing a Void app with Capacitor on both platforms, and this is the remaining router limitation in that integration.This adds
capacitor:support to Pages navigation. Capacitor uses that scheme by default on iOS, where the router currently rejects form submissions. The change also compares protocol and host for local navigation and action redirects, sinceURL.originreturns"null"for Capacitor URLs. It requires no new configuration or dependency.All 44 Pages client tests pass, including coverage for relative and absolute GET/POST visits, action redirects, different hosts, and rejected schemes. Seven of the new cases fail without this change. Formatting and lint pass for the changed files.
I also bundled the modified client source into a Void 1.1.11 / @void/react 1.1.11 app and tested it in Chromium, WebKit, an iOS 26.1 simulator, and an Android API 36.1 emulator. Rendering, hydration, form submission, D1 persistence, and the subsequent client-only page passed.
The full repository suite and workspace typecheck could not run locally because workspace dependencies and build outputs were missing. The focused tests used Vite+ 1.2.0 with
@void/edgeresolved to its workspace source.