Repository navigation
Finalize quota card sharing reward pause and UI updates - #3274
Merged
Merged
Conversation
Follow-up to the review of #543: - Continue/Retry no longer sends the reward's continuation_after_reward event while the reward is paused. - The share button and claim area are built only when the reward is on. - A promotional balance that would print as $0.00 counts as none, so the paused card shows the plain allowance instead of "Reward balance: $0.00". - The UI test states which card each page mounts instead of relying on the shipped default, renders the paused card in all 23 locales (RTL, 280 px) and shares one remount helper; test/compass-quota.mjs, which runs in CI, now mounts the paused card with a small fake DOM. - docs/compass-quota-rollout.md: the restore steps name the test that pins the flag, older lines no longer say the card offers the reward, and a note says the backend still grants claims until it gets its own pause. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follow-up to the review of #546: - PROVIDER_ICON_FILES maps webbrain_cloud_max to the Compass logo, so the paid tier no longer depends on one argument of the menu builder (the alias that modelIconUrl used to supply). - Clicking "More providers…" no longer syncs the button to the sentinel first. That dropped the provider's logo and its green/red connection status, which nothing checked again after Settings opened. - The picker comment in sidepanel.html and docs/providers-and-models.md describe the provider logo instead of the model's logo / engine icon. - Tests: a model change keeps the same logo element, Compass Max shows the Compass logo, and "More providers…" keeps the logo and status. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- agent.js: read both gate switches at once, and keep the current gate
when storage cannot be read. Seven test/run.js agent tests set
_skipPermissionGate directly with no storage, and two hung. Turning
prompts on from any writer, including an imported configuration, now
also ends a "this session only" skip.
- Permissions page: the open page follows the session skip live; it
ignored storage.session before.
- Skip dialog:
- it closes on a tab switch;
- it stays open, with its choices disabled, until the switch is saved,
so a second click can't reach the card underneath;
- it answers the card as currently rendered;
- its notice says prompts stay off when the stored setting is already
off, and it also posts for a scheduled task's card from another tab;
- on a short panel the card scrolls instead of overflowing;
- it names the safety checks that still stop or ask, in all 23
locales.
- The ⚡ glyph is out of the button's accessible name; the button no
longer carries data-i18n its sibling answers don't have.
- Tests:
- run.js loads permission-skip-copy.mjs with the other locale overlay
and follows the refactored gate code;
- the hydration harness stubs bindPermissionSkipButton;
- new cases: unreadable storage, import ending a session skip,
"session" while off for good, double activation, tab switch and
Permissions page;
- dialog screenshots only when PERMISSION_SKIP_UI_OUTPUT is set.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Follow-up to the review of #545 (as merged, with the name kept as Vision mode): - In the 22 translated descriptions the Off (Waymo) sentence came right before the original sentence describing what On does, so "the agent also reads the accessibility tree" was followed by "... instead of reading the accessibility tree". They now follow the English order: the analogy and On, then Off, then the rest. - Hebrew: "חיישנים" (sensors) had an Arabic letter in the middle. - Blog: only a file upload is a few-step handoff; a ledger workflow and WhatsApp/Telegram keep the tree while they last, and a whole-thread read keeps it for the rest of the task. - The Tesla mark's source and trademark note is recorded in icons/providers/SOURCES.md (both builds); the settings.html comment points there. - CHANGELOG [Unreleased] entry for the Tesla mark and explanation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
From the review's gap sweep: - Persian "رد کردن" means reject, so the button read "Reject all permissions" while it turns prompts off; it now says "continue without asking for permission". Hindi now skips permission prompts rather than "permissions". - storage.session lasts as long as the browser process: closing every window on macOS, or with Chrome running in the background, does not end it. The hint and notice now say "until you quit the browser" in all 23 locales. - Closing the dialog after its card is gone (the run ended) returned focus nowhere; it now falls back to the composer. Shift+Tab from the dialog container itself no longer leaves the focus trap. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Skip permissions: review fixes, incl. run.js hang now on main (follow-up to #544)
Vision mode (aka Tesla): description order, blog accuracy, mark attribution (follow-up to #545)
Model picker: Compass Max logo, keep status on "More providers…" (review follow-up to #546)
Quota card: finish pausing the $0.50 sharing reward (review follow-up to #543)
|
@esokullu is attempting to deploy a commit to the esokullu's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.