[vishnuv688]

Refs #300. Stacked on #428; merge that first, then this one shows only its own three commits.

Adds the Nightwatch adapter to the conformance suite, which brings it to three of the four adapters. The first run was red for the three reasons a new adapter is expected to be: one real adapter bug, three places where the suite had assumed every adapter looked like Selenium, and two documented differences to declare. All of it is resolved here, and the suite is green with every difference either fixed or declared.

The bug it found

A navigation the browser refused produced a Nightwatch row with result: null and no error: no red row, nothing in the Errors tab. Nightwatch reports such a failure as {status: -1, value: null, error} with the Error itself under error, and callbackError descended into the W3C value wrapper first, found null, and returned nothing. The wrapper is now read before descending. Six unit tests pin the shapes, built on the exact object the plugin's callback receives, and a changeset is included.

Suite assumptions it corrected

Assumption	What Nightwatch does	Change
A fill's text is the first string argument	setValue(selector, text) leads with the selector	The first string argument that is not the row's own selector
Run controls are served by a shell command	Reruns go through the backend's framework path with a registered config file	run-controls-are-served: a command or a configFile serves them
One driver request per user action	Its transport re-issues a refused navigation (measured 3 attempts, 1 s apart, with the plugin's own reads in between)	The fake counts a retry run as the one action the user issued; the run ends only with the next user action

Declared differences

Both carry their reason in the allowlist and show as allowlisted in the report:

• No Run-all. The backend reruns a Nightwatch config's suites and tests through its framework path; there is no whole-run entry. Already on the capability matrix.
• No-BiDi <script> fallback misses a page the test leaves within tens of milliseconds, the same race Selenium's fallback has.

Declaring them exposed two faults in how gaps were judged, fixed here: a gap listing only adapters-agree-* rules was never "occurring" and always "stale", so per-run rules are now judged by the run and comparison rules by the comparison (which reports its own stale gaps); and two adapters declaring the same gap on the same step no longer reject each other.

How Nightwatch runs

Through its own CLI, against a config and spec under scenarios/nightwatch/, with webdriver.start_process: false pointed at the fake WebDriver and the recording backend reached through the reuse handshake the plugin already honours. nightwatch and @wdio/nightwatch-devtools become dev dependencies of the conformance package so the config can resolve them.

Observed, not acted on

The plugin re-sends its session metadata 11 times for one session, and warns Cannot read properties of undefined (reading 'replace') when the session has no BiDi socket. Both harmless; worth a follow-up issue.

Verification

pnpm build, pnpm test (2580 tests, 55 in the conformance package), pnpm lint, pnpm typecheck and a frozen-lockfile install with CI's pnpm version: all green. The adapter fix was confirmed end to end: before it, the suite failed failed-command-has-error-row for Nightwatch; after it, the row carries net::ERR_FAILED at /broken, the browser's own text.

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; all three previous findings are fixed, and no new blocking issue was found.

Summary

Adds Nightwatch to the conformance suite and fixes missing errors on failed Nightwatch commands.

• The conformance suite now runs Nightwatch alongside its Selenium adapters.
• Failed Nightwatch commands now show the browser’s error on their action row.
• The suite reads Nightwatch fills and run controls using their actual shapes.
• Known adapter gaps now match the reports and comparisons that judge them.

_{Reviews (3) · Last reviewed commit: "fix(conformance): show a comparison's st..." · Reviewed by Greptile}