Repository navigation
Remove experimental labels from samplingMode in spec and explainer - #226
Merged
michaelwasserman merged 1 commit intoOct 27, 2026
Conversation
isaacahouma
force-pushed
the
sampling-mode-remove-experimental
branch
3 times, most recently
from
October 21, 2026 16:59
f6f9e6b to
a77c2fd
Compare
Removes the // **EXPERIMENTAL** WebIDL comments above LanguageModel.samplingMode and LanguageModelCreateCoreOptions.samplingMode in index.bs, renames the top README.md section to Updates and Deprecations, updates the Sampling Parameters overview to note that the legacy raw sampling parameter features are deprecated and only functional within web extension contexts while developers can use samplingMode presets instead, and removes a stale temperature reference in an availability() example.
isaacahouma
force-pushed
the
sampling-mode-remove-experimental
branch
from
October 21, 2026 17:05
a77c2fd to
5a19a71
Compare
isaacahouma
marked this pull request as ready for review
October 21, 2026 17:32
michaelwasserman
approved these changes
Oct 27, 2026
michaelwasserman
left a comment
michaelwasserman
left a comment
Collaborator
There was a problem hiding this comment.
lgtm with comment nits for optional followup
| unrestricted double temperature; | ||
|
|
||
| // **EXPERIMENTAL**: Only available in experimental contexts. | ||
| LanguageModelSamplingMode samplingMode; |
Collaborator
There was a problem hiding this comment.
Consider add a brief comment like "The requested sampling mode for this session."
| readonly attribute float temperature; | ||
|
|
||
| // **EXPERIMENTAL**: Only available in experimental contexts. | ||
| readonly attribute LanguageModelSamplingMode? samplingMode; |
Collaborator
There was a problem hiding this comment.
Consider adding a brief comment like "The resolved sampling mode for the session."
Maybe we can comment that it might be null in extension contexts, while those still support legacy params?
github-actions Bot
added a commit
that referenced
this pull request
Oct 27, 2026
) SHA: c2b9266 Reason: push, by michaelwasserman Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
// **EXPERIMENTAL**: Only available in experimental contexts.WebIDL comments aboveLanguageModel.samplingModeandLanguageModelCreateCoreOptions.samplingModeinindex.bs, renames## Experiments and UpdatesinREADME.mdto## Updates and Deprecations, updates theSampling Parametersoverview to note that the legacy raw sampling parameter features are deprecated and only functional within web extension contexts while developers can usesamplingModepresets instead, and cleans up a staletemperaturecomment in theavailability()example.Preview | Diff