Repository navigation
Conversation
miyazakh
commented
Oct 29, 2026
Contributor
- Restructure the build procedure as numbered steps: copy user_settings.h, build wolfSSL, then build wolfSSH.
- State that wolfSSL must be built beforehand with the same configuration (Debug/Release/DLL Debug/DLL Release) and platform (Win32/x64) as wolfSSH.
- Fix the wolfCryptDllRelease64 path to $(wolfCryptDir)\DLL Release\x64 to match ide/winvs/wolfssh.props.
- Restore indentation of the directory layout example.
- Fix grammar and code formatting in the English text.
- Japanese: fix mistranslations and missing text, unify terminology, and replace the GitHub URL with the ide\winvs location to match the English text.
- Restructure the build procedure as numbered steps: copy user_settings.h, build wolfSSL, then build wolfSSH. - State that wolfSSL must be built beforehand with the same configuration (Debug/Release/DLL Debug/DLL Release) and platform (Win32/x64) as wolfSSH. - Fix the wolfCryptDllRelease64 path to $(wolfCryptDir)\DLL Release\x64 to match ide/winvs/wolfssh.props. - Restore indentation of the directory layout example. - Fix grammar and code formatting in the English text. - Japanese: fix mistranslations and missing text, unify terminology, and replace the GitHub URL with the ide\winvs location to match the English text.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues block the Windows build documentation updates.
No open issues 🎉
What changed in this PR
This documentation-only PR clarifies the Windows build procedure for wolfSSH and aligns the English and Japanese instructions.
Changes:
- Organizes setup into numbered steps and specifies that wolfSSL must be built first with matching configuration and platform.
- Corrects the
wolfCryptDllRelease64path and restores directory-layout indentation. - Improves English formatting and grammar, and corrects Japanese translations and terminology.
| File | Description |
|---|---|
wolfSSH/src/chapter02.md |
Clarifies Windows build steps, prerequisites, and library paths. |
wolfSSH/src-ja/chapter02.md |
Aligns Japanese instructions with English and improves translation accuracy. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.