Skip to content

Fix wolfSSH Windows build instructions (section 2.4) - #290

Open
miyazakh wants to merge 1 commit into
wolfSSL:masterfrom
miyazakh:wolfssh-doc-windows-build
Open

miyazakh wants to merge 1 commit into
wolfSSL:masterfrom
miyazakh:wolfssh-doc-windows-build

Conversation

@miyazakh

Copy link
Copy Markdown
Contributor
  • Restructure the build procedure as numbered steps: copy user_settings.h, build wolfSSL, then build wolfSSH.
  • State that wolfSSL must be built beforehand with the same configuration (Debug/Release/DLL Debug/DLL Release) and platform (Win32/x64) as wolfSSH.
  • Fix the wolfCryptDllRelease64 path to $(wolfCryptDir)\DLL Release\x64 to match ide/winvs/wolfssh.props.
  • Restore indentation of the directory layout example.
  • Fix grammar and code formatting in the English text.
  • Japanese: fix mistranslations and missing text, unify terminology, and replace the GitHub URL with the ide\winvs location to match the English text.

- Restructure the build procedure as numbered steps: copy
  user_settings.h, build wolfSSL, then build wolfSSH.
- State that wolfSSL must be built beforehand with the same
  configuration (Debug/Release/DLL Debug/DLL Release) and platform
  (Win32/x64) as wolfSSH.
- Fix the wolfCryptDllRelease64 path to
  $(wolfCryptDir)\DLL Release\x64 to match ide/winvs/wolfssh.props.
- Restore indentation of the directory layout example.
- Fix grammar and code formatting in the English text.
- Japanese: fix mistranslations and missing text, unify terminology,
  and replace the GitHub URL with the ide\winvs location to match
  the English text.
Copilot AI balanced review requested due to automatic review settings October 29, 2026 01:30

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues block the Windows build documentation updates.

No open issues 🎉

What changed in this PR

This documentation-only PR clarifies the Windows build procedure for wolfSSH and aligns the English and Japanese instructions.

Changes:

  • Organizes setup into numbered steps and specifies that wolfSSL must be built first with matching configuration and platform.
  • Corrects the wolfCryptDllRelease64 path and restores directory-layout indentation.
  • Improves English formatting and grammar, and corrects Japanese translations and terminology.
File Description
wolfSSH/​src/​chapter02.md Clarifies Windows build steps, prerequisites, and library paths.
wolfSSH/​src-ja/​chapter02.md Aligns Japanese instructions with English and improves translation accuracy.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants