Skip to content

feat: allow to provide a linker script instead of using the included one - #958

Open
vhdirk wants to merge 1 commit into
wolfSSL:masterfrom
vhdirk:external-linker-script
Open

vhdirk wants to merge 1 commit into
wolfSSL:masterfrom
vhdirk:external-linker-script

Conversation

@vhdirk

@vhdirk vhdirk commented Oct 28, 2026

Copy link
Copy Markdown

We're doing some oddities in our linker script that differ from what is done by default. To that end, we'd like to provide our own linker script so we don't have to carry patches forward

We're doing some oddities in our linker script that differ from what is
done by default. To that end, we'd like to provide our own linker script
so we don't have to carry patches forward
Copilot AI balanced review requested due to automatic review settings October 28, 2026 14:53

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Explicitly supplied LSCRIPT_IN values are still overwritten by later target and option assignments, so custom linker scripts are not reliably preserved.

1 open issue
What changed in this PR

This PR makes wolfBoot’s default linker-script input configurable, allowing custom layouts without patching the root Makefile.

Changes:

  • Changes LSCRIPT_IN from an unconditional assignment (:=) to a conditional default (?=), preserving values already supplied through the environment or configuration.
File Description
Makefile Makes the initial linker-script selection conditional.

Review effort: Balanced

Comment thread Makefile
@vhdirk

vhdirk commented Oct 28, 2026

Copy link
Copy Markdown
Author

@danielinux I was planning on addressing the copilot review, but since you approved already, do you still need me to?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants