Skip to content

Fix use after free and rendering defects in user values #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aidangarske wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Fix use after free and rendering defects in user values #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7da6837
F-4760 - https://fenrir.wolfssl.com/finding/4760 - Take the KV refere…
aidangarske Oct 21, 2026
a5aae7b
F-8774 - https://fenrir.wolfssl.com/finding/8774 - Hold a KV referenc…
aidangarske Oct 21, 2026
a09da94
F-5559 - https://fenrir.wolfssl.com/finding/5559 - Return the key val…
aidangarske Oct 21, 2026
7f480f0
F-3442 - https://fenrir.wolfssl.com/finding/3442 - Render 64-bit KV i…
aidangarske Oct 21, 2026
185453f
F-3195 - https://fenrir.wolfssl.com/finding/3195 - Render KV floats w…
aidangarske Oct 21, 2026
4c4351b
F-6511 - https://fenrir.wolfssl.com/finding/6511 - Render non-finite …
aidangarske Oct 21, 2026
222f45c
F-4281 - https://fenrir.wolfssl.com/finding/4281 - Escape KV strings …
aidangarske Oct 21, 2026
02600b7
F-3869 - https://fenrir.wolfssl.com/finding/3869 - Cover rejection of…
aidangarske Oct 21, 2026
b775210
F-12517 - https://fenrir.wolfssl.com/finding/12517 - Reject empty use…
aidangarske Oct 21, 2026
58fca82
F-12515 - https://fenrir.wolfssl.com/finding/12515 - Keep the previou…
aidangarske Oct 21, 2026
02181dd
F-10509 - https://fenrir.wolfssl.com/finding/10509 - Access the user …
aidangarske Oct 21, 2026
f13bebc
F-13288 - https://fenrir.wolfssl.com/finding/13288 - Store the user v…
aidangarske Oct 21, 2026
7c7399b
F-12553 - https://fenrir.wolfssl.com/finding/12553 - Bound sentinel s…
aidangarske Oct 21, 2026
373b4d4
F-12553 - https://fenrir.wolfssl.com/finding/12553 - Bound base64 val…
aidangarske Oct 23, 2026
99ab225
F-3195 - https://fenrir.wolfssl.com/finding/3195 - Accept the longest…
aidangarske Oct 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/json/load_config.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@ static wolfsentry_errcode_t convert_uint8(JSON_TYPE type, const unsigned char *d
}

static wolfsentry_errcode_t convert_double(JSON_TYPE type, const unsigned char *data, size_t data_size, double *out) {
char buf[24];
/* fits the longest %.17g rendering, 24 characters */
char buf[25];
char *endptr;
double conv;

Expand Down Expand Up @@ -1735,15 +1736,15 @@ WOLFSENTRY_API wolfsentry_errcode_t wolfsentry_config_json_init_ex(
#ifdef WOLFSENTRY_HAVE_DESIGNATED_INITIALIZERS
.max_total_len = WOLFSENTRY_MAX_JSON_TOTAL_LEN,
.max_total_values = 0,
.max_number_len = 20,
.max_number_len = 24,
.max_string_len = WOLFSENTRY_KV_MAX_VALUE_BYTES,
.max_key_len = WOLFSENTRY_MAX_LABEL_BYTES,
.max_nesting_level = WOLFSENTRY_MAX_JSON_NESTING,
.flags = JSON_NOSCALARROOT
#else
WOLFSENTRY_MAX_JSON_TOTAL_LEN,
0,
20,
24,
WOLFSENTRY_KV_MAX_VALUE_BYTES,
WOLFSENTRY_MAX_LABEL_BYTES,
WOLFSENTRY_MAX_JSON_NESTING,
Expand Down
Loading
Loading