Repository navigation
Harden the notification log server example - #98
aidangarske wants to merge 10 commits into
Conversation
…hen issuer name rendering returns NULL
…ings on every verify callback return path
…s from peer certificate strings before logging
… offset zero when the circular log wraps
…h at shutdown when no rule route was checked out
…e values that overflow size_t before allocating
…e config file size returned by ftell
… before writing the decision list separator
…ddress-family labels written into the circular log JSON
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #98
Scan targets checked: wolfsentry-pr-general
Review type: general (no scan target covers the changed files)
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
Review tier: Lite
…label written into the circular log JSON
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #98
Scan targets checked: wolfsentry-pr-general
Review type: general (no scan target covers the changed files)
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
Fenrir's latest completed scan found no issues; clearing the prior automated change request.
F-5002- ca0b963 - The log server example now rejects the handshake when issuer name rendering returns NULL.F-5779- ea0a82c - The log server verify callback now frees its X509 name strings on every return path.F-5712- 4a36715 - The log server now strips control bytes from peer certificate strings before logging them.F-5778- 979181e - The circular log now evicts the entry at offset zero when it wraps.F-4704- c1f68eb - Shutdown in the log server now skips route dispatch when no rule route was checked out.F-4821- aae0a26 - The log server now rejects circlog-size values that overflow size_t before allocating.F-5073- 298fb3f - The log server no longer truncates the config file size returned by ftell.F-5008- 6826116 - The log server now checks buffer space before writing the decision list separator.F-4763- 5a18bcb - Event and address family labels written into the circular log JSON are now escaped.