Repository navigation
wolfssh: warn when a known host adds a key type - #1345
Open
ejohnstown wants to merge 1 commit into
Open
ejohnstown wants to merge 1 commit into
ejohnstown wants to merge 1 commit into
Conversation
The known_hosts search skips an entry whose host matches but whose key type differs, so a host pinned with one type that presents another was reported as an unknown host. The check now remembers that the host is known with another type and says so before offering to add the new one, as OpenSSH does. - note the first other-type entry's key type and line in the loop - print a warning with that entry, the host and the new fingerprint before the add prompt; a later same-type entry still matches or rejects as before - reject a server key type that is not printable ASCII before it is printed or stored - regress.c: add TestKnownHostsOtherType Issue: ZD-22634
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1345
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wolfssh client reported a host pinned in known_hosts with one key
type that presented another as an unknown host. It now says the host is
known with a different key type, naming the pinned entry, before asking.
different key, as before.
printed or stored.
Issue: ZD-22634