Repository navigation
wolfsshd: fix shell and SCP session setup - #1346
Closed
ejohnstown wants to merge 3 commits into
Closed
ejohnstown wants to merge 3 commits into
ejohnstown wants to merge 3 commits into
Conversation
wolfSSH_DoModes() now returns -1 without touching the terminal when tcgetattr() fails, instead of applying an uninitialized termios. A failed tcsetattr() is reported the same way, and wolfsshd logs it. - api.c: DoModes fails on a pipe and sets ECHO on a pty Issue: F-10546
A shell child killed by a signal now reports 128 plus the signal as its exit status. A failure after the fork kills and reaps the child and closes the parent's descriptors to it, and the resize context is cleared before the terminal it points at is closed. - SHELL_AbortChild() serves the post-fork setup failures - -r with no command now fails at the argument check in main() - sshd_exit_signal_test.sh checks a plain exit and a SIGKILL Issue: F-13327, F-14203, F-15571, F-14204
SCP_Subsystem() changes to pw_dir after dropping privileges, as the shell and SFTP do, so a relative remote path resolves from home rather than from the daemon's working directory, inside a chroot too. When home is unreachable, SCP and the shell start from "/", as OpenSSH does. Both log that only outside a chroot. - sshd_scp_home_test.sh uploads to "." and finds the file in home Issue: F-15502
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes to how wolfsshd starts and tears down shell, exec and SCP
sessions, and to terminal mode handling in wolfSSH_DoModes().
wolfsshd logs it
descriptors
Issue: F-10546, F-13327, F-14203, F-14204, F-15571, F-15502