Repository navigation
client: TPM key file fixes and default public key - #1349
Open
ejohnstown wants to merge 2 commits into
Open
ejohnstown wants to merge 2 commits into
ejohnstown wants to merge 2 commits into
Conversation
readKeyBlob() checks each part of the key file against its destination before reading it, and every failure now returns an error with the file closed. wolfSSH_TPM_InitKey() refuses a key auth that does not fit the blob, and the key material is wiped once it is no longer needed. - reject a public size over pubAreaBuffer, a private part over key->priv - return BUFFER_E on a short read; parse errors go through exit - refuse a -K value longer than the auth buffer - wipe the key blob and session on return, the TPM key on cleanup Issue: F-8855, F-10558, F-10604, F-10601, F-10602, F-10603
Without -i the client loads the built-in private key, so load its public half too and publickey auth with the default keys works. A -j file or a TPM key still supplies its own public key. Issue: F-13905
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1349
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The example client's TPM key path now checks the key file against its
buffers and wipes the key material, and the client offers its built-in
public key when no -i is given.
and closes the file when the parse fails
TPM key are wiped
auth works with the sample keys
Issue: F-8855, F-10558, F-10604, F-10601, F-10602, F-10603, F-13905