Repository navigation
internal: keep userauth verifier error codes - #1350
Open
ejohnstown wants to merge 1 commit into
Open
ejohnstown wants to merge 1 commit into
ejohnstown wants to merge 1 commit into
Conversation
The public-key userauth verifiers now return the error from the step that failed, and map only the wolfCrypt key decode itself to WS_CRYPTO_FAILED. The X.509 ECDSA verifier checks the signature's algorithm name like its siblings. - EccCert and Ed25519: argument, allocation, parse and type errors keep their own codes - Rsa and RsaCert: a hash with no OID, or a failed encode, is WS_CRYPTO_FAILED before the verify - EccCert: accept the declared x509v3 name or RFC 6187's ecdsa-sha2 name for the same curve; anything else is WS_INVALID_ALGO_ID - unit: cover each case; add wolfSSH_TestDoUserAuthRequestEccCert Issue: F-11654, F-12544, F-15665
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1350
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 3 in-scope changed file(s) opened by the reviewer; not opened: wolfssh/internal.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The public-key userauth verifiers now return the error from the step
that failed, and the X.509 ECDSA verifier checks the signature's
algorithm name like its siblings. No change lets a login through.
verifying
name for the same curve; anything else is WS_INVALID_ALGO_ID
Issue: F-11654, F-12544, F-15665