Repository navigation
ossh: drop the dead ID_UNKNOWN branch - #1352
Open
ejohnstown wants to merge 1 commit into
Open
ejohnstown wants to merge 1 commit into
ejohnstown wants to merge 1 commit into
Conversation
GetOpenSshKey() leaves no keyId for a key-type name it does not know and returns WS_UNIMPLEMENTED_E itself, so IdentifyOpenSshKey() never sees ID_UNKNOWN after a failure and passes that result straight on. - tests/unit.c adds test_IdentifyOpenSshKeyUnknownName() for the WS_UNIMPLEMENTED_E result on an unknown key-type name. Issue: F-13330
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1352
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 2 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetOpenSshKey() returns WS_UNIMPLEMENTED_E itself for a key-type name
it does not know, so the ID_UNKNOWN check in IdentifyOpenSshKey() can
never be true.
This and #1351 both add a test at the same spot in tests/unit.c;
whichever merges second will be rebased onto the other.
Issue: F-13330