Repository navigation
ssh: stop reading behind a large output backlog - #1353
Open
ejohnstown wants to merge 1 commit into
Open
ejohnstown wants to merge 1 commit into
ejohnstown wants to merge 1 commit into
Conversation
wolfSSH_worker() and wolfSSH_stream_read() now flush before reading once more than WOLFSSH_MAX_OUTPUT_BACKLOG bytes are queued, and return WS_WANT_WRITE without reading if the flush leaves it over. A peer that never reads can no longer grow outputBuffer one reply per packet. - WOLFSSH_MAX_OUTPUT_BACKLOG defaults to two MAX_PACKET_SZ, overridable - A smaller backlog still reads first, keeping the PR 856 order - regress: unknown-id and GLOBAL_REQUEST floods with blocked sends stop at the cap and drain once the peer reads Issue: F-16808
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1353
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 3 in-scope changed file(s) opened by the reviewer; not opened: wolfssh/internal.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfSSH_worker() and wolfSSH_stream_read() stop taking input once more
than WOLFSSH_MAX_OUTPUT_BACKLOG bytes of replies are queued, so a peer
that never reads can no longer grow outputBuffer without bound.
backlog is still over
drain once the peer reads
Issue: F-16808