Repository navigation
ssh, internal: send one KEXINIT per key exchange - #1354
Open
ejohnstown wants to merge 1 commit into
Open
ejohnstown wants to merge 1 commit into
ejohnstown wants to merge 1 commit into
Conversation
RFC 4253 7.1 allows one KEXINIT from each side per key exchange. wolfSSH_TriggerKeyExchange() is now a no-op returning WS_SUCCESS while any keying is in progress, and SendKexInit() skips once this side's KEXINIT is out, so the stored copy feeding the exchange hash stays put. - covers the highwater callback, whose byte and message marks can both fire in one rekey - covers the window after SendNewKeys() clears the self-keying flag while the peer's NEWKEYS is still due - regress: second trigger, nested highwater and NEWKEYS-window tests Issue: F-16775
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #1354
Scan targets checked: wolfssh-src, wolfssh-bugs
Coverage: 2 of 4 in-scope changed file(s) opened by the reviewer; not opened: tests/regress.c, wolfssh/ssh.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Each side sends one KEXINIT per key exchange, as RFC 4253 Section 7.1
requires, so the copy that feeds the exchange hash is never replaced
mid-exchange.
the highwater callback firing twice in one rekey
Issue: F-16775