Repository navigation
additional hardening check on ECC key import with CAAM port - #11672
JacobBarthelmeh wants to merge 1 commit into
Conversation
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Blinding can truncate oversized scalars before validation, allowing invalid input to pass the new check.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
This PR hardens ECC private-key imports in the CAAM port.
Changes:
- Adds range validation for plaintext private keys.
- Corrects propagation of key-blinding errors.
| File | Description |
|---|---|
| wolfcrypt/src/ecc.c | Adds CAAM plaintext-key validation and fixes blinding error assignments. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11672
Scan targets checked: wolfcrypt-src, wolfcrypt-bugs
Coverage: 1 of 1 in-scope changed file(s) opened by the reviewer
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite

ZD22446
Thanks to Lemohang Khaile (strokep) for the hardening suggestion.