Repository navigation
tests: gate test_wolfSSL_X509_check_email_san on no time. - #11950
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the email SAN test and helper guard changes.
No open issues 🎉
What changed in this PR
This PR addresses an X.509 email SAN test failure in builds without ASN time support, following regression testing in #11936.
Changes:
- Skip
test_wolfSSL_X509_check_email_sanwhenNO_ASN_TIMEorUSER_TIMEis defined. - Apply the same guards to its certificate-generation helper.
| File | Description |
|---|---|
tests/api/test_ossl_x509.c |
Add matching time-feature guards to the email SAN test and its helper. |
Review effort: Balanced
|
douzzer
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gate
test_wolfSSL_X509_check_email_sanon no time.Test was failing with
NOT_COMPILED_INin when built with no asn time.found while testing: