Repository navigation
Broadcast vertices-to-bounds conversion over extra dimensions - #682
Open
nawaaaaaAaar wants to merge 2 commits into
Open
nawaaaaaAaar wants to merge 2 commits into
nawaaaaaAaar wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #682 +/- ##
==========================================
+ Coverage 85.78% 86.98% +1.19%
==========================================
Files 13 16 +3
Lines 2364 3373 +1009
Branches 183 316 +133
==========================================
+ Hits 2028 2934 +906
- Misses 303 390 +87
- Partials 33 49 +16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Oct 23, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #163.
Add an optional
core_dimsargument tovertices_to_boundsso one or two vertex dimensions can be converted while extra dimensions are broadcast over. The implementation follows theapply_ufuncand ellipsis-indexing approach suggested in the issue. The existing call signature and one-/two-dimensional defaults remain supported.Example:
Reproduction and verification
The issue's four-dimensional profile example raises
ValueErroron unchanged upstreamee13cb860717299ca8f66d35461e5e50910f3d47. All five initial new broadcasting regression cases fail before the production change.git diff --check: passed.Dask core dimensions must each occupy a single chunk; broadcast dimensions retain their chunking. This is documented on the new parameter.
Hosted checks
The documentation build and pre-commit.ci have passed. Some test/type matrix jobs are still pending. Codecov's aggregate patch gate is currently failing at 76.47%, while its
unittestsflag reports 100% patch coverage; its report also warns that the comparison is 132 commits behind main. This remains an unresolved hosted gate. No coverage threshold or workflow configuration has been weakened to bypass it.AI-assisted implementation and testing, with tests executed locally.