Skip to content

Fix Identifier tests #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vjik merged 2 commits into from
Oct 18, 2026
Merged

Fix Identifier tests #508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61f1736
Fix Identifier tests
vjik Oct 14, 2026
9cbde73
fix
vjik Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions tests/QueryBuilderTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
namespace Yiisoft\Db\Pgsql\Tests;

use Closure;
use InvalidArgumentException;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\DataProviderExternal;
use PHPUnit\Framework\Attributes\TestWith;
Expand Down Expand Up @@ -686,8 +687,6 @@ public static function dataBuildIdentifier(): iterable
yield ['s.t.name', '"s"."t"."name"'];
yield [['t', 'na.me'], '"t"."na.me"'];
yield ['LOWER(name)', '"LOWER(name)"'];
yield ['[[name]]', '"[[name]]"'];
yield ['{{%t}}.name', '"{{%t}}"."name"'];
yield ['*', '"*"'];
yield ['arr[1]', '"arr[1]"'];
yield ['a"b', '"a""b"'];
Expand All @@ -701,4 +700,23 @@ public function testBuildIdentifier(string|array $name, string $expected): void

$this->assertSame($expected, $qb->buildExpression(new Identifier($name)));
}

public static function dataBuildIdentifierWithQuoteSqlSequences(): iterable
{
yield ['[[name]]', '"[[name]]"'];
yield ['{{%t}}.name', '"{{%t}}"."name"'];
}

#[DataProvider('dataBuildIdentifierWithQuoteSqlSequences')]
public function testBuildIdentifierWithQuoteSqlSequences(string|array $name, string $expected): void
{
$qb = $this->getSharedConnection()->getQueryBuilder();

$this->expectException(InvalidArgumentException::class);
$this->expectExceptionMessage(
'Identifier ' . $expected . ' must not contain sequences processed by '
. '"Yiisoft\\Db\\Schema\\QuoterInterface::quoteSql()", such as "[[...]]" or "{{...}}".',
);
$qb->buildExpression(new Identifier($name));
}
}
Loading