Repository navigation
fix(gemset): use batch launchers on Windows - #353
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #352.
Managed gems currently resolve to extensionless RubyGems scripts on every platform. Windows cannot spawn those scripts directly, causing error 193 when starting language servers such as Solargraph and Ruby LSP.
.batlauncher on Windows using the host OS already passed toGemset.The shared helper handles both cached and newly installed managed language servers, as well as the managed debugger. Custom binary paths and PATH lookup are unchanged.
Verification
TMPDIR=/tmp cargo test— 83 tests passed; rerun before opening this PR.TMPDIR=/tmp cargo fmt --check— passed.TMPDIR=/tmp cargo clippy --all-targets --all-features --locked -- -D warnings— passed.git diff --check— passed.TMPDIR=/tmpavoids a local build-cache socket-path length limit. Windows/Zed end-to-end startup was not tested on this macOS machine. The WASM build was not run because the target is not installed.