Repository navigation
Register default bff icons collection for core/icon block - #524
Open
firestar300 wants to merge 1 commit into
Open
firestar300 wants to merge 1 commit into
firestar300 wants to merge 1 commit into
Conversation
cedric07
reviewed
Oct 20, 2026
| } | ||
|
|
||
| $candidates = [ | ||
| get_theme_file_path( 'dist/images/' . $source_subdir ), |
Contributor
There was a problem hiding this comment.
Normal de chercher aussi les svg dans ce dossier ? ça vient de src/img/static non ?
|
|
||
| $candidates = [ | ||
| get_theme_file_path( 'dist/images/' . $source_subdir ), | ||
| get_theme_file_path( 'src/img/icons/' . $source_subdir ), |
Contributor
There was a problem hiding this comment.
Ici aussi, ce dossier n'est pas déployé.
Je sais plus comment tu as géré la copie des svg dans ton autre PR? dans un dossier dédié ? ou à la racine de dist/images comme le dossier static ?
Contributor
There was a problem hiding this comment.
Pardon je crois que j'ai mal lu la PR, on a des sous dossiers dédiés pour les icônes ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Changes which blocks editors can use and replaces the default core icon picker with theme SVGs on init; misconfigured paths or filters could leave the Icon block with an empty or unexpected library.
Overview
Adds a new
Iconframework service that registers General (beapi-sprite) and Social (beapi-social) icon collections for the WordPress Icon block (7.1+), loading icons from built or source SVG folders underdist/images/{sprite|social}orsrc/img/icons/{sprite|social}. Collections, labels, properties, and whether to drop the defaultcoreicon library are overridable viabff_icon_collections,bff_icon_label,bff_icon_properties, andbff_unregister_core_icon_collection.The service is bootstrapped in
Framework, andcore/iconis no longer blocklisted in the editor so authors can use the block with the theme sets. SVGO config only gains a short comment on extra plugins.Reviewed by Cursor Bugbot for commit 4ec21e4. Bugbot is set up for automated code reviews on this repo. Configure here.