Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions config/svgo.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ module.exports = {
name: 'removeViewBox',
active: false,
},
// Plugins that are not in the "preset-default" and that you want to activate
'removeTitle',
'convertStyleToAttrs',
],
Expand Down
2 changes: 2 additions & 0 deletions inc/Framework.php
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
use BEA\Theme\Framework\Services\Editor;
use BEA\Theme\Framework\Services\Editor_Patterns;
use BEA\Theme\Framework\Services\Gravity_Forms;
use BEA\Theme\Framework\Services\Icon;
use BEA\Theme\Framework\Services\Menu;
use BEA\Theme\Framework\Services\Svg;
use BEA\Theme\Framework\Services\Theme;
Expand Down Expand Up @@ -38,6 +39,7 @@ class Framework {
Editor_Patterns::class,
Gravity_Forms::class,
Svg::class,
Icon::class,
Acf::class,
Menu::class,
Breadcrumb::class,
Expand Down
1 change: 0 additions & 1 deletion inc/Services/Editor.php
Original file line number Diff line number Diff line change
Expand Up @@ -244,7 +244,6 @@ public function gutenberg_blocks_allowed( $allowed_blocks, \WP_Block_Editor_Cont
'core/accordion-heading',
'core/accordion-item',
'core/accordion-panel',
'core/icon',
// Theme & site (unused).
'core/archives',
'core/calendar',
Expand Down
222 changes: 222 additions & 0 deletions inc/Services/Icon.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,222 @@
<?php

namespace BEA\Theme\Framework\Services;

use BEA\Theme\Framework\Service;
use BEA\Theme\Framework\Service_Container;

/**
* Registers theme icon collections for the WordPress Icon block (7.1+).
*/
class Icon implements Service {

private const COLLECTION_SPRITE = 'beapi-sprite';

private const COLLECTION_SOCIAL = 'beapi-social';

/**
* @param Service_Container $container Service container.
*/
public function register( Service_Container $container ): void {}

/**
* @param Service_Container $container Service container.
*/
public function boot( Service_Container $container ): void {
add_action( 'init', [ $this, 'register_icon_collections' ] );
add_action( 'init', [ $this, 'unregister_core_icon_collection' ], 20 );
}

/**
* @return string
*/
public function get_service_name(): string {
return 'icon';
}

/**
* Registers icon collections and icons from built SVG files.
*
* @return void
*/
public function register_icon_collections(): void {
if ( ! function_exists( 'wp_register_icon_collection' ) || ! function_exists( 'wp_register_icon' ) ) {
return;
}

$collections = apply_filters(
'bff_icon_collections',
[
self::COLLECTION_SPRITE => [
'source_subdir' => 'sprite',
'label' => __( 'General', 'beapi-frontend-framework' ),
'description' => __( 'Theme UI icons.', 'beapi-frontend-framework' ),
],
self::COLLECTION_SOCIAL => [
'source_subdir' => 'social',
'label' => __( 'Social', 'beapi-frontend-framework' ),
'description' => __( 'Social network icons.', 'beapi-frontend-framework' ),
],
]
);

foreach ( $collections as $collection_slug => $collection_args ) {
$this->register_collection( (string) $collection_slug, $collection_args );
}
}

/**
* Unregisters the default WordPress core icon collection from the Icon block library.
*
* Runs on init at priority 20 so core icons are registered first (priority 10).
*
* @return void
*/
public function unregister_core_icon_collection(): void {
if ( ! function_exists( 'wp_unregister_icon_collection' ) ) {
return;
}

if ( ! apply_filters( 'bff_unregister_core_icon_collection', true ) ) {
return;
}

wp_unregister_icon_collection( 'core' );
}

/**
* @param string $collection_slug Collection slug passed to wp_register_icon_collection().
* @param array<string, mixed> $collection_args Collection configuration.
*
* @return void
*/
private function register_collection( string $collection_slug, array $collection_args ): void {
if ( ! function_exists( 'wp_register_icon_collection' ) ) {
return;
}

$source_subdir = isset( $collection_args['source_subdir'] ) ? (string) $collection_args['source_subdir'] : '';

if ( '' === $source_subdir ) {
return;
}

wp_register_icon_collection(
$collection_slug,
[
'label' => $collection_args['label'] ?? $collection_slug,
'description' => $collection_args['description'] ?? '',
]
);

$icons_directory = $this->resolve_icons_directory( $source_subdir );

if ( null === $icons_directory ) {
return;
}

$svg_files = glob( $icons_directory . '/*.svg' );

if ( false === $svg_files ) {
return;
}

foreach ( $svg_files as $svg_file ) {
$this->register_icon_file( $collection_slug, $svg_file );
}
}

/**
* Resolves the directory containing standalone SVG files for a collection.
*
* @param string $source_subdir Subdirectory name (e.g. sprite, social).
*
* @return string|null Absolute path or null when not found.
*/
private function resolve_icons_directory( string $source_subdir ): ?string {
$source_subdir = preg_replace( '/[^a-z0-9-]/', '', strtolower( $source_subdir ) );

if ( '' === $source_subdir ) {
return null;
}

$candidates = [
get_theme_file_path( 'dist/images/' . $source_subdir ),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normal de chercher aussi les svg dans ce dossier ? ça vient de src/img/static non ?

get_theme_file_path( 'src/img/icons/' . $source_subdir ),

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ici aussi, ce dossier n'est pas déployé.

Je sais plus comment tu as géré la copie des svg dans ton autre PR? dans un dossier dédié ? ou à la racine de dist/images comme le dossier static ?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pardon je crois que j'ai mal lu la PR, on a des sous dossiers dédiés pour les icônes ?

];

foreach ( $candidates as $candidate ) {
if ( ! is_dir( $candidate ) ) {
continue;
}

$real_path = realpath( $candidate );

if ( false !== $real_path ) {
return $real_path;
}
}

return null;
}

/**
* @param string $collection_slug Collection slug.
* @param string $svg_file Absolute path to an SVG file.
*
* @return void
*/
private function register_icon_file( string $collection_slug, string $svg_file ): void {
if ( ! function_exists( 'wp_register_icon' ) ) {
return;
}

$real_file = realpath( $svg_file );

if ( false === $real_file || ! is_readable( $real_file ) ) {
return;
}

$icon_slug = pathinfo( $real_file, PATHINFO_FILENAME );
$icon_slug = preg_replace( '/[^a-z0-9-]/', '', strtolower( (string) $icon_slug ) );

if ( '' === $icon_slug ) {
return;
}

$icon_name = $collection_slug . '/' . $icon_slug;
$label = apply_filters(
'bff_icon_label',
$this->format_icon_label( $icon_slug ),
$icon_slug,
$collection_slug
);

$properties = apply_filters(
'bff_icon_properties',
[
'label' => $label,
'file_path' => $real_file,
],
$icon_name,
$collection_slug
);

if ( empty( $properties['file_path'] ) && empty( $properties['content'] ) ) {
return;
}

wp_register_icon( $icon_name, $properties );
}

/**
* @param string $icon_slug Icon filename without extension.
*
* @return string
*/
private function format_icon_label( string $icon_slug ): string {
$label = str_replace( [ '-', '_' ], ' ', $icon_slug );

return ucwords( $label );
}
}
Loading