Repository navigation
feat(desktop-gpui): enable the language picker in release builds - #3434
Closed
richiemcilroy wants to merge 4 commits into
Closed
richiemcilroy wants to merge 4 commits into
richiemcilroy wants to merge 4 commits into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
|
@greptileai review |
…llow the system language
… the permission prompts
richiemcilroy
force-pushed
the
feat/gpui-language-picker-release
branch
from
October 26, 2026 22:24
5c5b432 to
b6f26ae
Compare
Member
Author
|
@greptileai review |
Member
Author
|
Merged as part of #3516, together with current main and a full audit of every GPUI surface and translation. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns the language picker on for release builds, now that the settings, dialogs, editor panels and editor shell are translated (#3424, #3423, #3422, #3428).
Stacked on the i18n integration branch so the diff here is only these three commits. It gets retargeted to
mainonce those four PRs land.Changes
Picker in release builds (
i18n/mod.rs,settings_window.rs)CAP_GPUI_LANGUAGE_PICKERandpicker_enabled(). The Language section always shows on the General page.Systempreference now follows the system language in release builds too. Before, a release build stayed English on a non-English system because the picker was hidden.uiLanguageandCAP_GPUI_LOCALEbehave as before.macOS language declaration and permission prompts (
Info.plist,tauri.conf.json,macos/*.lproj)CFBundleDevelopmentRegionandCFBundleLocalizationsfor the seven shipped languages, so macOS treats Cap as localized.InfoPlist.stringsfor each language, so the camera, microphone and screen recording permission prompts use the system language.zh-CNmaps tozh-Hans.lproj.Update, quit and Open Recording dialogs (
updates.rs,menus.rs,installer.rs)Update menu while downloading (
updates.rs,menus.rs,settings_window.rs)Downloading { fraction: None }and stays that way when the server sends no size. The menu treated that as "Download update…" (enabled), and clicking it only said Cap was already getting the update ready.Availablevariant. A real check never uses it, because it asks in a dialog before downloading.Tests
dialogs_surface_testspins every new English key to the literal it replaced, including formatted messages with their arguments (update_and_quit_messages_format_like_the_code_they_replaced).tests.rsdrops the picker-gating tests and pinsmenu.file.open_prompt.Available(enabled "Download update…") and an unsized download (disabled "Downloading update…").cap-desktop-gpuitest suite passes on macOS: 1496 passed, 0 failed.

Confidence Score: 5/5
The PR appears safe to merge; no actionable defects were found.Summary
Enables the language picker in release builds and lets the default language follow the user's system preferences.
No actionable new issues were found. The full PR diff was reviewed because the previous-review ancestry and shared-base checks did not pass. No previous review threads were supplied. Builds, tests, and native UI checks were not run.
Reviews (2) · Last reviewed commit: "fix(desktop-gpui): keep a running update..." · Reviewed by Greptile