Repository navigation
fix(web): keep voice-note processing owned by its recording - #3464
Open
vedanth-jadhav wants to merge 3 commits into
Open
vedanth-jadhav wants to merge 3 commits into
vedanth-jadhav wants to merge 3 commits into
Conversation
Contributor
|
Someone is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Author
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A voice note can finish waveform decoding after its recorder unmounts or the take is canceled. The old completion still calls
onFinish, which starts the comment upload, and can reset a newer take. A delayed mixer from an abandoned startup can also stop the replacement microphone.Keep asynchronous stop/decoding work tied to its recording run, and release only the abandoned stream when a stale mixer completes. The current take still produces its blob, duration and waveform normally. If MediaRecorder rejects start or restart, release the microphone and mixer and reset the recorder instead of leaving capture active.
Validation: 23 focused tests pass, including nine mounted voice-recorder lifecycle cases, two existing comment-recorder lifecycle tests and 12 waveform tests. Four ownership cases fail on baseline 8dd141d; the successful recording and late-permission controls pass. Two encoder-start failure cases also fail on the initial PR head and pass with the follow-up. The delayed-stop regression verifies the replacement can finish; removing its run-ownership guard makes the test fail. The tests use real React hooks and controlled media/mixer events, without claiming physical microphone validation. Scoped strict TypeScript, Biome, CI YAML parsing and git diff --check pass. Full web build/typecheck was not run. Current main 97c8d63 has the same affected code.


Confidence Score: 5/5
The reviewed changes appear safe to merge.Summary
Keeps voice-note completion tied to its recording and releases capture when the encoder cannot start.
Reviews (2) · Last reviewed commit: "test(web): cover delayed voice recorder ..." · Reviewed by Greptile