[tintinhamans]

Replaces #640, #641, #633, #636 and #643, closed as folded into this PR. Upstream fixes from TheSuperHackers/GeneralsGameCode, ported as commits with the upstream number in the title:

• bugfix(w3dwater): Skip rivers that overflow the dynamic index buffer TheSuperHackers/GeneralsGameCode#3489, fix(worldheightmap): Free the legacy cliff state buffer when loading blend tile data TheSuperHackers/GeneralsGameCode#3482, bugfix(worldheightmap): Reject map sizes that overflow the cell array allocations TheSuperHackers/GeneralsGameCode#3486: rivers overflowing the index buffer, legacy cliff buffer leak, oversized map cell arrays
• fix(lanapi): Fix GameInfo memory leaks in LANAPI::OnGameStart(), LANAPI::RequestGameLeave() TheSuperHackers/GeneralsGameCode#3462, fix(lanapi): Delete the lobby player when they leave the lobby TheSuperHackers/GeneralsGameCode#3499: LANAPI GameInfo and lobby player leaks
• bugfix(network): Close sockets that fail to bind TheSuperHackers/GeneralsGameCode#3488, fix(network): Release the disconnect chat message after sending it TheSuperHackers/GeneralsGameCode#3498: sockets that fail to bind, disconnect chat message leak
• fix(addoncompat): Close fullviewport.dat file handle after reading it TheSuperHackers/GeneralsGameCode#3476, fix: Close leaked system handles in GameWindowManager, ImageCollection, MainMenuUtils TheSuperHackers/GeneralsGameCode#3497, fix(maputil): Close the file and free the buffer when a map preview copy fails TheSuperHackers/GeneralsGameCode#3485: leaked file and system handles
• perf(displaystring): Rebuild static text only when its hotkey setting changes TheSuperHackers/GeneralsGameCode#3443: static text no longer rebuilds its sentence and texture every frame (winRepaint 0.155 to 0.099 ms per frame upstream), plus the two bugs that rebuild hid
• bugfix(w3d): Fix leaked surface copy in screenshot and movie capture TheSuperHackers/GeneralsGameCode#3477: every screenshot and movie capture leaked a back buffer sized surface
• bugfix(gamewindow): Remove destroyed windows from the modal stack and prevent duplicate modals for the same window TheSuperHackers/GeneralsGameCode#3224: destroyed windows are removed from anywhere in the modal stack and a window can't be modal twice, replacing the approach of bugfix(gui): Remove destroyed windows from the modal stack #583
• perf(script): Reduce cost of ScriptEngine::findScript() by around 85% TheSuperHackers/GeneralsGameCode#3096: ScriptEngine::findScript() around 85% cheaper
• bugfix(pathfinder): Fix rare retail pathfinding crashes in forwardInsertionSortRetailCompatible() and putOnClosedList() TheSuperHackers/GeneralsGameCode#3113: two rare retail pathfinding crashes
• bugfix(pathfinder): Prevent crash in Pathfinder::processHierarchicalCell TheSuperHackers/GeneralsGameCode#3296: a Generals pathfinding crash in Pathfinder::processHierarchicalCell
• perf(particlesys): Batch same type particles to reduce cost of particle rendering by 15 to 30% TheSuperHackers/GeneralsGameCode#3155 with its follow-up bugfix(particlesys): Render lone streak type particles as regular particles TheSuperHackers/GeneralsGameCode#3320: same type particles drawn in batches, 15 to 30% less particle rendering cost. It needs refactor(particlesys): Cleanup retail smudge particle type identification TheSuperHackers/GeneralsGameCode#3162, unify(particlesys): Move W3DParticleSys.h to Core TheSuperHackers/GeneralsGameCode#3172 and tweak(particlesys): Cleanup volume particle depth handling and add INI field to control it TheSuperHackers/GeneralsGameCode#3188; the last adds an optional VolParticleDepth INI field that defaults to the old hard coded depth
• bugfix(texturefilter): Fix blocky shroud edges from misconfigured texture filters TheSuperHackers/GeneralsGameCode#3434: blocky shroud edges from misconfigured texture filters
• fix(htree): Reject invalid W3D hierarchy pivot counts TheSuperHackers/GeneralsGameCode#3195: invalid W3D hierarchy pivot counts are rejected instead of leaving a hierarchy without pivots
• fix(controlbar): Prevent null dereference in ControlBar::showRallyPoint() if RallyPointMarker was not defined in INI TheSuperHackers/GeneralsGameCode#3304, fix(controlbar): Prevent null dereference in ControlBar::updateSpecialPowerShortcut() TheSuperHackers/GeneralsGameCode#3330, fix(pointgroup): Prevent null dereference in PointGroupClass::RenderVolumeParticle() when no size array is given TheSuperHackers/GeneralsGameCode#3280, fix(terrainvisual): Prevent null dereference in W3DTerrainVisual::loadRequire() TheSuperHackers/GeneralsGameCode#3306, fix(modeldraw): Prevent null dereference in W3DModelDraw::handleClientRecoil() TheSuperHackers/GeneralsGameCode#3301, fix(gamewindowtransitions): Prevent null dereference in GameWindowTransitionsHandler::remove() TheSuperHackers/GeneralsGameCode#3329: null dereferences in ControlBar::showRallyPoint, ControlBar::updateSpecialPowerShortcut, PointGroupClass::RenderVolumeParticle, W3DTerrainVisual::loadRequire, W3DModelDraw::handleClientRecoil and GameWindowTransitionsHandler::remove
• fix(ini): Prevent using unitialized stack variable in INI::parseBitString8() TheSuperHackers/GeneralsGameCode#3307, fix(milesaudiomanager): Prevent heap-buffer-overflow read in MilesAudioManager::selectProvider() TheSuperHackers/GeneralsGameCode#3281, fix(firewallhelper): Prevent stack-buffer-overflow write in FirewallHelperClass::getManglerName() TheSuperHackers/GeneralsGameCode#3346: an uninitialized stack variable in INI::parseBitString8, an out of bounds read in MilesAudioManager::selectProvider, a stack buffer overflow in FirewallHelperClass::getManglerName
• fix(ww3d2): Copy string setter inputs before freeing potentially aliased storage TheSuperHackers/GeneralsGameCode#3313, fix(audio): Copy SoundSceneObjClass state safely TheSuperHackers/GeneralsGameCode#3247, fix(gameinfo): Clear GameSlot IP on reset TheSuperHackers/GeneralsGameCode#3311: string setters that freed their buffer before copying an aliased input, a pure virtual call when copying a SoundSceneObjClass, a stale GameSlot IP after a reset
• bugfix(debug): Skip system-modal crash dialogs in headless runs TheSuperHackers/GeneralsGameCode#3030: system modal crash dialogs no longer keep a headless run alive
• fix(w3ddisplay): Fix cinematic text display string leak TheSuperHackers/GeneralsGameCode#3517: the cinematic text leaked a DisplayString every frame
• fix(ingameui): Properly delete ControlBar and ReplayControl game windows on resolution change and/or shutdown TheSuperHackers/GeneralsGameCode#3414: the ControlBar and ReplayControl windows are deleted properly on resolution change and shutdown
• bugfix: Prevent the game from freezing during scripted camera movements in multiplayer TheSuperHackers/GeneralsGameCode#3390: the game froze during scripted camera movements in multiplayer when a stalling player halted it. Approved but not merged upstream yet, and applied by hand to both W3DDisplay.cpp copies because GO still has one per game

MapReaderWriterInfo.h, Recorder.h, GameSpyGameInfo.h, GameWindowManagerScript.cpp, part_emt.cpp, part_ldr.cpp, W3DDisplay.h, InGameUI.h and InGameUI.cpp exist once per game here and are changed in both. The GameInfo destructor and the ImageCollection fix already exist, so those parts are skipped. Upstream's replay checks passed for every port, and particle templates are not part of the INI CRC, so stock data gives the same ini: value.

z_generals builds, the Generals copies are not compiled. Not run in game.

[github-actions]

⚠️ Title/Commit Validation Failed

Invalid commit messages:

• bugfix(pathfinder): Prevent crash in Pathfinder::processHierarchicalCell (#3296)
  PR titles and commit messages must follow conventional commits format:

type: Description
type(scope): Description

Allowed types: bugfix, build, chore, ci, docs, fix, feat, perf, refactor, revert, style, test, tweak, unify

See CONTRIBUTING.md for details.