Repository navigation
bugfix(gamewindow): Remove destroyed windows from the modal stack and prevent duplicate modals for the same window - #643
Closed
tintinhamans wants to merge 1 commit into
Conversation
… prevent duplicate modals for the same window (TheSuperHackers#3224) (cherry picked from commit 6512dc6)
Author
|
Folded into #638. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports TheSuperHackers#3224 (
cherry-pick -x), replacing the approach of #583.winUnsetModalnow removes the window from anywhere in the modal stack andwinDestroycalls it unconditionally, so theremoveWindowFromModalStackhelper goes away.winSetModalmoves a window that is already modal to the top instead of adding a second entry.processDestroyListdrops its duplicate cleanup and asserts nothing points at the window.Applied to both
GeneralsandGeneralsMD, identical to upstream.