Repository navigation
Add Laravel 13 support and build on the laravel package skeleton - #1
Merged
Merged
Conversation
…port - Adopt laravel/package-skeleton, the base of the `laravel package` installer command: composer scripts, Larastan level 7, Pest type coverage and arch tests, strict types, Pint rules, Testbench workbench, CI matrix, release notes and changelog automation, AGENTS.md and the local agent skills - Require PHP ^8.3 and Laravel 12 or 13; Laravel 11 no longer receives security fixes - Move the logo assets to public/ and add the `simplepay` publish group tag; the publish targets stay the same - Keep the API response on SimplePayApiException (getResponseData()), so the redirectUrl of a 3DS challenge (3004) is no longer lost - Throw on JSON encoding failures instead of signing `false`
Strict types no longer coerce "123456" to int, so cast it explicitly like the other response DTOs do.
Larastan 3.9.x allows PHPStan 2.2, but crashes with it (FunctionCallParametersCheck::check() gained parameters). The prefer-lowest Windows lane resolved exactly that pair; Larastan 3.10 is the first release built for PHPStan 2.2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mi változott
laravel packageparancsának vázára (laravel/package-skeleton) épül:composer test,test:unit,analyse,lint;declare(strict_types=1)minden PHP-fájlban;AGENTS.md(aCLAUDE.mderre mutat) és a váz agent-skilljei.php artisan vendor:publish --tag=simplepayegyszerre publikálja a configot és a logókat. A régisimplepay-configéssimplepay-assetstag, valamint a célútvonalak nem változtak.SimplePayApiExceptionmostantól megőrzi az API teljes válaszát (getResponseData()).redirectUrl-je sem volt elérhető (3004-es hibakód).prefer-lowest/prefer-stable;Ellenőrzés
composer test(Larastan, Pint, típuslefedettség, Pest: 78 teszt) zöld PHP 8.4-en, Laravel 13.37 / Testbench 11.3 / Pest 5.3 mellett.prefer-lowest(12.69, Pest 4.6);prefer-stable(12.70);prefer-lowest(13.30, Pest 4.6).transactionId-je TypeError-t dobott volna.Megjegyzések a review-hoz
declare_strict_typesszabálya és a váz fájljai.SimplePayServiceProvider: publish tagek és apublic/asset-útvonal;SimplePayApiException::getResponseData();PaymentResponse: int-cast;JSON_THROW_ON_ERRORaClient-ben és a webhookban;resources/assetsmappából apublic/alá kerültek. A fájlok nem változtak, és a publikálás célja ugyanaz..gitattributesmiatt atests, aworkbench, azart, azofficial-docsés az agent-fájlok nem kerülnek a Composer-csomagba.laravel packagefolyamatával készült a következő elemekkel: config, routes, facade, assets, Boost skill, Dependabot, issue-sablon, changelog és security policy. AFUNDING.ymlkimaradt.breaking,enhancement,bug,documentation,dependencies,maintenance,skip-changelog,duplicate;mainvédett, az update-changelog workflow-nak pusholási jog kell.