Repository navigation
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request fixes an issue where file paths containing single quotes (such as src/dev's polyfills/polyfills.js) caused build failures when generating polyfill and global style imports. The fix replaces single-quoted string interpolation with JSON.stringify to safely escape paths in the generated import statements. Additionally, corresponding unit tests have been added to verify this behavior for both polyfills and global styles. There are no review comments to address, and the changes look solid.
alan-agius4
requested changes
Oct 19, 2026
alan-agius4
added
action: cleanup
alan-agius4
approved these changes
Oct 19, 2026
alan-agius4
added
action: merge
The application builder generated the global styles and polyfills entry modules by wrapping each configured path in single quotes without escaping. A path containing a single quote, such as `src/dev's theme/theme.css`, produced an invalid import and the build failed with "Could not resolve" or a syntax error. Generate the import specifiers with `JSON.stringify` so that such paths are quoted correctly.
alan-agius4
force-pushed
the
fix/quoted-global-entry-paths
branch
from
October 19, 2026 08:38
4754d8f to
87464b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The application builder generated the global styles and polyfills entry modules by wrapping each configured path in single quotes without escaping. A path containing a single quote, such as
src/dev's theme/theme.css, produced an invalid import and the build failed with "Could not resolve" or a syntax error.Generate the import specifiers with
JSON.stringifyso that such paths are quoted correctly.