Skip to content

chore(deps): bump ty to 0.0.89 - #1196

Merged
vdusek merged 2 commits into
masterfrom
chore/bump-ty
Oct 20, 2026
Merged

vdusek merged 2 commits into
masterfrom
chore/bump-ty

Conversation

@vdusek

@vdusek vdusek commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Bumps ty from 0.0.86 to 0.0.89 and fixes the new errors:

  • LogRecord.exc_info is typed ... | Literal[False] | None in typeshed, so the tests narrow it by truthiness before indexing.
  • Scrapy declares Spider.parse as a CallbackT attribute for type checkers, so every def parse override trips invalid-mutable-override (on by default since ty 0.0.87). The rule is off only for the spider modules in the docs and the e2e Actor sources, which keeps the docs example free of ignore comments.

✍️ Drafted by Claude Code

@vdusek vdusek added adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. labels Oct 20, 2026
@vdusek vdusek self-assigned this Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.11%. Comparing base (92abc2b) to head (595295d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1196      +/-   ##
==========================================
- Coverage   93.14%   93.11%   -0.03%     
==========================================
  Files          54       54              
  Lines        3691     3691              
==========================================
- Hits         3438     3437       -1     
- Misses        253      254       +1     
Flag Coverage Δ
e2e 31.59% <ø> (ø)
integration 51.61% <ø> (-0.03%) ⬇️
unit 89.89% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vdusek
vdusek marked this pull request as ready for review October 20, 2026 08:25
@vdusek
vdusek requested a review from Mantisus October 20, 2026 08:25
@apify-service-account apify-service-account added the tested Temporary label used only programatically for some analytics. label Oct 20, 2026

@Mantisus Mantisus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@apify-approval-mirror apify-approval-mirror Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mirroring approval from @Mantisus.

@vdusek
vdusek merged commit b047e06 into master Oct 20, 2026
41 of 42 checks passed
@vdusek
vdusek deleted the chore/bump-ty branch October 20, 2026 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants