Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,16 @@ include = [
[tool.ty.overrides.rules]
unresolved-import = "ignore"

# Scrapy declares `Spider.parse` as a `CallbackT` attribute for type checkers, so every `def parse` override narrows it.
[[tool.ty.overrides]]
include = [
"docs/**/scrapy_project/src/spiders/*.py",
"tests/e2e/test_scrapy/actor_source/spider_*.py",
]

[tool.ty.overrides.rules]
invalid-mutable-override = "ignore"

[tool.coverage.report]
exclude_lines = ["pragma: no cover", "if TYPE_CHECKING:", "assert_never()"]

Expand Down
2 changes: 1 addition & 1 deletion tests/unit/actor/test_actor_log.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ async def test_actor_logs_messages_correctly(caplog: pytest.LogCaptureFixture) -
assert record.levelno == level
assert record.message == message
if exception:
assert record.exc_info is not None
assert record.exc_info
assert record.exc_info[0] is type(exception[0])
assert isinstance(record.exc_info[1], type(exception[0]))
assert str(record.exc_info[1]) == str(exception[0])
2 changes: 1 addition & 1 deletion tests/unit/scrapy/test_async_thread.py
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ async def boom() -> None:

errors = [record for record in caplog.records if record.levelno >= logging.ERROR]
assert len(errors) == 1
assert errors[0].exc_info is not None
assert errors[0].exc_info
assert str(errors[0].exc_info[1]) == 'boom'


Expand Down
2 changes: 1 addition & 1 deletion tests/unit/scrapy/test_scheduler.py
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def test_next_request_logs_exception_before_propagating(
errors = [record for record in caplog.records if record.levelno >= logging.ERROR]
assert len(errors) == 1
(error,) = errors
assert error.exc_info is not None
assert error.exc_info
assert isinstance(error.exc_info[1], RuntimeError)
assert str(error.exc_info[1]) == 'boom'

Expand Down
42 changes: 21 additions & 21 deletions uv.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading