Repository navigation
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. 🚀 Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Replace the pure-Dart nostr.Keys(secret).public derivations (about 5.6 ms each on an iPhone SE) with derivePublicKeyHex, including the one in the settings identity row's build method. Co-authored-by: george <973be878edd6d4f79692a3827f20a6f7fe0ed0362f269ff6b6ba8867033d7d8e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Tom Brow <tomb@block.xyz>
58bf4c4 to
4f36965
Compare
|
@codex review |
🔐 Codex Security Review
Review SummaryOverall Risk: NONE
FindingsNo concrete security, correctness, or reliability findings were identified. Notes
Generated by Codex Security Review | |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Follows #8654.
Deriving an x-only public key from a secret key with
nostr.Keys(secret).publiccosts about 5.6 ms in pure Dart on an iPhone SE (2nd gen, Profile). The app does it in 10 places, including relay config, the signed-event relay'spubkeygetter, push lease checks, status updates, and the settings identity row'sbuildmethod. This routes all of them throughderivePublicKeyHexfrom #8654, which takes 16.5 µs on the same device.Behavior is unchanged for valid keys: output is the same lowercase hex. For a malformed or out-of-range key the thrown type changes from nostr's
InvalidKeyExceptiontoArgumentError; every affected site either catches all errors or rethrows its ownFormatException/StateError, and nothing inlibortestmatches on the old type.Sites that need a full
nostr.Keysobject (key generation,AccountIdentityStore) are unchanged.Validation
derivePublicKeyHexis checked againstnostr.Keysfor 64 random keys in perf(mobile): sign events with native libsecp256k1 on iOS and Android #8654'sevent_signing_test.dart.buzz-review-completed (agent review, Codex and security review clean; device validation above; human app test not applicable under the mobile testing exception)
🤖 Generated with Claude Code