Repository navigation
Conversation
Add a buzz_secp256k1 package that builds vendored bitcoin-core/libsecp256k1 v0.8.0 (ecdh, extrakeys, schnorrsig) through a Dart build hook, and route every nostr.Event.from signing site through signNostrEvent, which keeps the nostr event-id serialization and moves pubkey derivation and BIP-340 signing to native code. Co-authored-by: george <973be878edd6d4f79692a3827f20a6f7fe0ed0362f269ff6b6ba8867033d7d8e@sprout-oss.stage.blox.sqprod.co> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Tom Brow <tomb@block.xyz>
The BIP-340 vectors and native-vs-Dart cross checks live in the package and were not part of the mobile test run. Also drop a stale cost comment. Co-authored-by: george <973be878edd6d4f79692a3827f20a6f7fe0ed0362f269ff6b6ba8867033d7d8e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Tom Brow <tomb@block.xyz>
Replace the pure-Dart nostr.Keys(secret).public derivations (about 5.6 ms each on an iPhone SE) with derivePublicKeyHex, including the one in the settings identity row's build method. Co-authored-by: george <973be878edd6d4f79692a3827f20a6f7fe0ed0362f269ff6b6ba8867033d7d8e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Tom Brow <tomb@block.xyz>
ecdhSharedSecret used pointycastle's BigInt point multiplication, which is slow (about 5.9 ms on an iPhone SE) and not constant time. It now calls libsecp256k1's secp256k1_ecdh with a raw-x hash callback, wiping the decoded secret key afterwards. Co-authored-by: george <973be878edd6d4f79692a3827f20a6f7fe0ed0362f269ff6b6ba8867033d7d8e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Tom Brow <tomb@block.xyz>
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Bravo. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
brow
force-pushed
the
mobile-native-pubkey-derivation
branch
from
October 28, 2026 23:30
58bf4c4 to
4f36965
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8655.
ecdhSharedSecret, the input to every NIP-44 conversation key (preferences, read state, reminders, themes, mutes, stars, sections, sort, pairing, agent observer), used pointycastle's BigInt point multiplication. That costs about 5.9 ms per call on an iPhone SE (2nd gen, Profile) and is variable time in the secret scalar. It now calls libsecp256k1's constant-timesecp256k1_ecdhthroughecdhXfrom #8654 (39.8 µs on the same device), returning the same raw x-coordinate NIP-44 requires. The decoded secret key bytes are zeroed after the call.Invalid keys now throw
ArgumentErrorinstead of pointycastle's errors; callers already treat any throw as a failed derivation.Validation
ecdh_test.dartcompares the native result with the previous pointycastle algorithm for 32 random key pairs, checks the NIP-44 v2get_conversation_keyvector (secret 1, peer pubkey of secret 2), and checks rejection of a zero secret, an off-curve public key and wrong lengths.🤖 Generated with Claude Code