Repository navigation
Conversation
Route the existing pure-Dart signature checks (NIP-OA profiles and owner attestations, Solo me_* records, pairing events) through verifiedNostrEventFromJson and verifySchnorrHex, and sign NIP-OA owner authorizations with signSchnorrHex. Incoming relay events are still not verified. Co-authored-by: george <973be878edd6d4f79692a3827f20a6f7fe0ed0362f269ff6b6ba8867033d7d8e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Tom Brow <tomb@block.xyz>
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #8656.
The app already verifies signatures in a few places: NIP-OA agent profiles and owner attestations, Solo
me_*records (agent inventory, archived agents, assistants, sync), and pairing events. Each usednostr.Event.fromJson's pure-Dart BIP-340 verify, about 11.2 ms per event on an iPhone SE (2nd gen, Profile). This routes them throughverifiedNostrEventFromJsonandverifySchnorrHex, which keep the same checks (timestamp range, canonical id, Schnorr signature) and the samenostrexception types, with the signature check in libsecp256k1 (40 µs). NIP-OA owner authorizations are now signed withsignSchnorrHex, which removes the last pure-Dart Schnorr call inlib.Incoming relay events are still not verified; that stays a separate decision.
Validation
nostr.Schnorr.🤖 Generated with Claude Code