Skip to content

resolve: apply_language_gate filters in place - #572

Merged
bompus merged 1 commit into
fork/consolidatedfrom
perf/gate-retain-inplace
Oct 28, 2026
Merged

bompus merged 1 commit into
fork/consolidatedfrom
perf/gate-retain-inplace

Conversation

@bompus

@bompus bompus commented Oct 28, 2026

Copy link
Copy Markdown
Owner

Summary

  • apply_language_gate now retains its input Vec rather than into_iter().filter().collect() — drops one Vec<Arc<KNode>> allocation per ref through the hottest resolve path; gate verdicts identical.
  • Elements were already Arc clones (refcount bumps), so the collect was pure Vec-buffer churn.

Test plan

  • kernel builds (build-kernel.mjs --quick)
  • __tests__/kernel-resolve-parity.test.ts — 8/8

retain keeps the input Vec's allocation instead of building a second via
into_iter+collect — one Vec alloc per ref, same gate verdicts.
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 11 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

Run configuration
Commits

Reviewing files that changed from the base of the PR and between dfb8866 and a08e46e.

Files selected for processing: 1
  • codegraph-kernel/src/resolve/names.rs
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@bompus

bompus commented Oct 28, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@bompus
bompus merged commit 645abbb into fork/consolidated Oct 28, 2026
6 of 7 checks passed
@bompus
bompus deleted the perf/gate-retain-inplace branch October 28, 2026 02:21
bompus added a commit that referenced this pull request Oct 28, 2026
Adds the six landed rows to the benchmark follow-up table and updates the
measured head + README revision. pretix settle: 4.73 -> ~3.5 s (-26%,
two profiled runs) across #569-#572 with exact graph parity.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant