Skip to content

resolve: apply_language_gate filters in place #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bompus merged 1 commit into from
Oct 28, 2026
Merged

resolve: apply_language_gate filters in place #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 10 additions & 15 deletions codegraph-kernel/src/resolve/names.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,26 +62,21 @@ impl KernelResolver {
}

/// applyLanguageGate (name-matcher.ts).
pub(super) fn apply_language_gate(&mut self, candidates: Vec<Arc<KNode>>, r: &ResolveRefIn) -> Vec<Arc<KNode>> {
pub(super) fn apply_language_gate(&mut self, mut candidates: Vec<Arc<KNode>>, r: &ResolveRefIn) -> Vec<Arc<KNode>> {
// retain in place — one Vec alloc per ref instead of two.
if r.reference_kind == "references" || r.reference_kind == "function_ref" {
return candidates
.into_iter()
.filter(|c| same_language_family(&c.language, &r.language) || self.objc_header_global_ref(c, r))
.collect();
candidates.retain(|c| same_language_family(&c.language, &r.language) || self.objc_header_global_ref(c, r));
return candidates;
}
if r.reference_kind == "imports" {
return candidates
.into_iter()
.filter(|c| {
!crosses_known_family(&c.language, &r.language)
&& !crosses_code_boundary(&c.language, &r.language)
})
.collect();
candidates.retain(|c| {
!crosses_known_family(&c.language, &r.language)
&& !crosses_code_boundary(&c.language, &r.language)
});
return candidates;
}
candidates.retain(|c| !crosses_code_boundary(&c.language, &r.language) || self.has_bridge_evidence(c, r));
candidates
.into_iter()
.filter(|c| !crosses_code_boundary(&c.language, &r.language) || self.has_bridge_evidence(c, r))
.collect()
}

/// hasBridgeEvidence (name-matcher.ts): a call may cross a language
Expand Down