Repository navigation
feat(ask-ai): offer a11y as a product again - #492
Merged
Merged
Conversation
Reverses abfddf6, which dropped a11y from askBrowserStackAI while Ask AI was in limited alpha. Atlas has served a11y throughout; only the tool stopped offering it. The same four places move back together: * `PRODUCTS` in types.ts is `["tm", "a11y", "tra"]`. * the `product` describe text in register.ts names a11y (Accessibility). * `NEEDS_A11Y_SCAN_ID` and `NEEDS_A11Y_CONFIG_ID` in tool-handoff.ts point at askBrowserStackAI with product "a11y" again, keeping "start a new scan" / "create one" as the fallback, since Ask AI is still entitled per account and the agent route can be refused. The test that pinned the two-product enum now pins the three-product one, checks the describe text names every product, and checks that any product a handoff names is one the schema accepts, so dropping a product without moving its handoffs fails a test instead of shipping an instruction to make a rejected call. npm run build, tsc --noEmit and eslint are clean; 84 files / 1299 tests pass. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Collaborator
|
This has been merged into #502 (898f31e), which now ships it to One change in the merge: the longer handoff text here would have taken |
This was referenced Oct 23, 2026
Aaryan430
added a commit
that referenced
this pull request
Oct 23, 2026
Brings in #502 (Automate links, share links, large exports, one-page view, scan-run comparison, #510's device note, #513's scan settings, #492's Ask AI pointer). Conflicts resolved by keeping both sides: - fetchAccessibilityIssues resolves the source first, then compareWith goes to the scan-run comparison for a scan and to the app-build comparison for an app build; pageUrl and exportTaskId pass through for web reports, and the next-page hint keeps the pageUrl with the exact remaining count. - Report links: a share link is unwrapped first, then app and manual-report links, then Automate links. - The CSV parser pages through the shared pageOf/sortBySeverity; its local copy is dropped. - The run-started message carries both the device note and the accessibility guidance. - The ids handoff keeps main's Ask AI pointer within the 200-character budget; the app lists' searchCapability pointer moves to the buildId and appReportId argument descriptions. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
askBrowserStackAIacceptsa11y(Accessibility) as aproductagain, alongsidetmandtra.This reverses abfddf6, which dropped a11y from the tool while Ask AI was in limited alpha. Atlas has served a11y the whole time; only the tool stopped offering it.
Changes
src/tools/ask-browserstack/types.ts:PRODUCTSis["tm", "a11y", "tra"]. The "deliberately ABSENT" comment is replaced with one listing what has to move together if a product is ever dropped.src/tools/ask-browserstack/register.ts: theproductdescribe text namesa11y (Accessibility).src/tools/tool-handoff.ts:NEEDS_A11Y_SCAN_IDandNEEDS_A11Y_CONFIG_IDpoint ataskBrowserStackAIwith product"a11y"again. They keep "start a new scan" / "create one" as a fallback, because Ask AI is still entitled per account and the agent route can be refused.tests/tools/askBrowserstackE2E.test.ts: the test that pinned the two-product enum now checks:tm, a11y, tra;productdescribe text names every product;PRODUCT_LABELSinrelay.tsalready hada11y: "Accessibility"and is unchanged.Testing
npm run build,tsc --noEmitandeslintare clean.vitest run: 84 files, 1299 tests passed.A version bump to 2.2.4 is stacked on this PR in a separate PR.
🤖 Generated with Claude Code