Repository navigation
structdiff: diff json:"-," fields like encoding/json does - #7207
Merged
Merged
Conversation
GetStructDiff skipped any field whose JSON name is "-", which also dropped json:"-," / json:"-,omitempty" fields that encoding/json serializes under the key "-". Skip only the exact tag json:"-" via structaccess.IsSkippedField, as IsEqual, structaccess and structwalk already do. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 0669a35
Top 6 slowest tests (at least 2 minutes):
|
janniklasrose
approved these changes
Oct 28, 2026
Collaborator
Integration test reportCommit: 3b1d281
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GetStructDiffskipped every field whose JSON name is-, includingjson:"-,"/json:"-,omitempty"fields that encoding/json serializes under the key"-". It now skips only the exact tagjson:"-"viastructaccess.IsSkippedField, whichIsEqual,structaccessandstructwalkalready use. Before this changeIsEqualcould report two values as different whileGetStructDiffreturned no changes.The change is reported at path
-, the same formstructwalkemits andstructaccess.Getresolves.No type in this repo or in databricks-sdk-go uses such a tag (only test fixtures do), so this is a consistency fix with no user-visible effect today.
This pull request and its description were written by Isaac.