Repository navigation
Conversation
Collaborator
Integration test reportCommit: bb50766
Top 6 slowest tests (at least 2 minutes):
|
structdiff and structwalk re-parsed struct tags for every visited field, and each package kept its own copy of the field rules (flattened embeds, json:"-", EmbeddedSlice, ForceSendFields). structaccess.GetStructInfo now computes them once per type for structdiff, structwalk and structaccess. No behavior change. Co-authored-by: Isaac <no-reply@databricks.com>
denik
force-pushed
the
denik/structs-field-info
branch
from
October 28, 2026 14:28
152acef to
bb50766
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
structdiffandstructwalkre-parsed struct tags on every visited field, and each package kept its own copy of the field rules (flattened embeds,json:"-",EmbeddedSlice,ForceSendFields). The copies already drifted twice (#7207, #7224).structaccess.GetStructInfonow computes these once per type, andstructdiff,structwalkandstructaccessuse it. No behavior change.JobSettings fixtures (
go test -bench . -benchmem ./libs/structs/structdiff), median of 8, allocations unchanged:libs/dyn/convertkeeps its own struct info: it also tracksdyn.Valuefields and walks embedded structs breadth-first.Stacked on #7224. Previous: #7205
This pull request and its description were written by Isaac.