Repository navigation
Conversation
…ructwalk FieldByName also finds a ForceSendFields promoted from an embedded struct. That list can only name the embedded struct's fields (the SDK marshaller rejects other names), so it must not decide whether the outer struct's own fields are forced. structaccess and libs/dyn/convert already look only at the declaring struct. Co-authored-by: Isaac <no-reply@databricks.com>
Collaborator
Integration test reportCommit: 4b3dff0
Top 6 slowest tests (at least 2 minutes):
|
denik
marked this pull request as ready for review
October 28, 2026 15:33
denik
enabled auto-merge
October 28, 2026 15:34
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
structdiffandstructwalklooked upForceSendFieldswithFieldByName, which also finds one promoted from an embedded struct, and used it for the outer struct's own fields. That list can only name the embedded struct's fields (the SDK marshaller rejects other names), so it was only ever applied by mistake: to an outeromitemptyfield that shadows an embedded one. Both now look only at the struct that declares the field, asstructaccessandlibs/dyn/convertalready do.No current type is affected: the shadowing fields are
resources.ClusterPolicydefinition/policy_family_definition_overrides, whose embedded list config loading never fills with those names, andQualityMonitor/QualityMonitorStatetable_name, which is notomitempty.Next: #7221 moves these field rules into a shared per-type cache.
This pull request and its description were written by Isaac.