Repository navigation
Take sa out of the vocabulary, so Maria de Sa keeps its surname (#857) - #879
Merged
Merged
Conversation
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #879 +/- ##
=======================================
Coverage 99.07% 99.07%
=======================================
Files 47 47
Lines 4781 4781
=======================================
Hits 4737 4737
Misses 44 44 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…adings (#857) Marking sa ambiguous left the SA / SA pairs in tse-donors parting and its title reading took the slots ma does not. No corpus shows a rank or a person writing it as a credential. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…labels, stale prose (#857) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 25, 2026
Merged
derek73
added a commit
that referenced
this pull request
Oct 25, 2026
* Prepare the 2.6.0 release notes, README and migrate guide Write the 2.6 release-log summary, name Dott.ssa and Sig.na (not Sig.ra, already a title in 2.5.0) in the Italian-salutations bullet and drop its SIG.RA case example, which 2.5.0 already repaired the same way. Add the 2.6 shapes to migrate.rst's "Changed in" list, each checked against the 1.4.0 wheel, and lead README.rst with 2.6. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix stale code-side prose found by the 2.6.0 release sweep - CAPITALIZATION_EXCEPTIONS' docstring used dphil as an unlisted acronym; #797 listed it, so use dclinpsy as docs/customize.rst does. - Reads: lines: _post_rules reads Policy.name_order (O6, #875) and _comma reads Policy.unlisted_dotted_suffixes (#872); _assign's Implements line omitted H8 (#835). - Three tests/v2/cases.py notes still called md title vocabulary, which #853 removed. - config/__init__ says the data modules re-export the TOML-compiled sets (#737). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix stale design-doc and AGENTS.md prose found by the 2.6.0 sweep - AGENTS.md's TITLES/suffix dual list counted ten words plus a "twelfth" md after #879 took sa out; name both md and sa as former duals. - The CAPITALIZATION_EXCEPTIONS split-default demo (AGENTS.md and migrate.rst) used dphil, a shipped mask since #797, so setting it showed nothing. Use dclinpsy, re-measured 2026-10-25: the edit reaches only a freshly built Constants. - decisions/vocabulary-model and decisions/C13 head notes record that #853 superseded md's title reading. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix stale user docs found by the 2.6.0 sweep; record the pickle break - A Lexicon, Policy or Parser pickled by 2.5.0 raises ValueError on load (after_given_titles, #835; two_family_names, #754, unmentioned until now). Give it its own release-log bullet and a line in migrate.rst's list of 2.x breaks; measured, 2.5.0 ParsedName and HumanName pickles still load. - usage.rst's input-shapes paragraph now names H8's trailing salutation after a family comma (#835). - locales.rst points default vocabulary at nameparser/vocab/*.toml; migrate.rst says nameparser.config exposes the compiled sets. - concepts.rst names two_family_names beside name_order. - customize.rst's two-family-names section gives decisions/O6's PSC figure for Portuguese filers instead of an unmeasured comparison. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Release 2.6.0 Clear PRE_RELEASE, set CITATION.cff to 2.6.0, and stamp the release log. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Fix the review findings on the 2.6.0 release sweep - decisions/S7's (10) argued from md as a title/suffix dual and C13's head note left Smith, MD PhD Ma off its superseded list; both note #853 now. - config/__init__ and migrate.rst: the Korean surname list is not compiled from TOML. - migrate.rst's j.r.r. entry: repair writes the capital, it does not keep one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Bump certifi to 2026.10.23 in uv.lock Closes Dependabot alert 6: certifi 2026.5.20 bundles emSign root CAs with compromised intermediate keys. certifi reaches only the dev group (sphinx -> requests); nameparser has no runtime dependencies. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * Lead the 2.6.0 highlights with two family names; make each lead a sentence Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #857.
saleaves the vocabulary: its military reading (Seaman Apprentice, a title) and its credential reading are both refused on the word (excluded), so it reads as any name word does. The Portuguese surname Sá written without its accent is the one bearer the corpora show.How it got here: marking
saambiguous fixedMaria de Sabut left all 255 SÁ / SA pairs in tse-donors (#843) parting (a one-case name ending inSAstill read a suffix, S6), andsa's title reading took the slot in front of a name and alone after a family comma (Smith, Sa→ title, whereSmith, Ma→ given). Neither reading has a bearer in the corpora: every name read withSaas a title is a person named Sa (Sa Liu,Sa ad Hariri), and every SA / S.A. suffix is a company, the South African qualifierFCP(SA), or initials typed without stops. The 167 NPPES providers who write it have not been read by item.Readings that change
Maria de Sa,MARIA DE SA,maria de sa→ familyde Sa/DE SA/de sa(was familyde, suffixSa);Joao Sa,ANA SA,ANA SILVA SA→ familySa/SA.Mrs Sa Li→ titleMrs, givenSa(the second title is gone);SA Smith→ givenSA.John Smith SA→ middleSmith, familySA(was suffixSA);Smith, SA→ givenSA(was suffix, Should parse("Smith, Jr.") put "Jr." in title rather than suffix? #296's audit row);John Smith, SA→ givenSA, familyJohn Smith(the name merged into the family, the reading any unlisted two-letter caps word gets; 1.4.0 through 2.5.0 read suffixSA),Smith, John SA→ middleSA,, SA→ givenSA(about 25 after-comma names across ctgov-officials and fec-individuals; NPPES's 167 providers who write it have not been read by item);John Smith S.A.andSmith, S.A.go through the unlisted-dotted rule and reportsuffix-or-name; a parenthesisedFCP (SA)is a nicknameSA(25 names in ctgov-officials). A caller who needsSAas a credential adds it to their own lexicon; the exclusions are removable if corpus evidence turns up.Local corpora (
snapshot.py --local, against base 8c965d7, 2026-10-25)SAas part of the family name (ADAO DE SA FERREIRA→ familyDE SA FERREIRA, was familyDE, suffixSA FERREIRA).local_corpora.py pairs tse-donors --agreementreads 0 accent-only pairs with two surnames where the base read 255 SÁ / SA.(SA)nickname); psc-individuals: 40 of 1,034,888; ukec-individuals: 0.Docs and records
tests/v2/rules_budget.jsonre-recorded (rules/C8 back to its old size); snapshot and rules corpus re-recorded; field-sweep count 1403 → 1406; the pairs-view test now uses RÁ / RA.migrate.rstneeds a "Changed in" entry at release.🤖 Generated with Claude Code