Repository navigation
Conversation
A profile mirrors a GitHub account at its @handle, as GitHub's ProfileOwner, so organizations can get one later. Users keep their GitHub ID, which never changes, and find their profile by it. The handle, name, avatar, bio, location and website live on the profile, and the code calls the username a handle. The API sends both handle and username for older clients. The old columns on users stay unused and nullable until a follow-up drops them, so the code running during the deploy keeps working.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueFinishing Touches
Comment |
mnapoli
marked this pull request as draft
October 25, 2026 21:43
mnapoli
added this pull request to stack #1158
October 25, 2026 21:48
This was referenced Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Groundwork for org pages (#938). A user's GitHub identity moves to a new
Profilemodel, which mirrors what GitHub's GraphQL calls aProfileOwner: an account with a profile page, user or organization. Orgs can then get a profile later without being users.No user-visible change intended.
Changes
profilestable:type,github_id,handle,name,avatar_url,bio,location,website,github_synced_at.github_id(it never changes) and find their profile by it.companystays on users, since only GitHub users have one.$user->handle,$user->name, etc. still read from the user, through the profile, which always comes eager-loaded. Writing them on a user throws: they change on$user->profile.handlein code, routes (@{user:handle}), frontend types and tests. API responses send bothhandleandusernamefor older clients.usersstay, nullable and unused, so the code still running during the deploy keeps working. The follow-up PR drops them.schema_version3 (username→handle).CreateLocalUseraction.New columns, per the data guidelines:
users, not added.typetells users from organizations.github_id,typeandgithub_synced_atare not serialized.DeleteUser.Limitations
Summary by CodeRabbit
usernamefields for compatibility with older clients.