Repository navigation
Check rich fallback coverage with a plain loop - #98
Merged
Merged
Conversation
On a 16-bit wchar_t platform (Windows) pdfium::CodePointView is a small class meant for range-based for loops, not a range std::ranges::all_of accepts, so FindRichFallback() no longer compiled for win32-x64 and win32-arm64. Elsewhere CodePointView is WideStringView, which is why the Mac and Linux builds were fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the win32-x64 and win32-arm64 builds, broken since the fonts work (#93):
On a 16-bit
wchar_tplatformpdfium::CodePointViewis a small class meant for range-basedforloops, not a rangestd::ranges::all_ofaccepts. On Mac and Linux it isWideStringView, so those builds were fine.FindRichFallback()now checks coverage with a plain loop, likeCoversText()and every otherCodePointViewuse.Local checks (darwin-arm64): 1315 unit tests pass; embedder tests unchanged (the 12 known Mac golden failures), including the font fallback and rich text tests. The Windows builds need CI.