Skip to content

Check rich fallback coverage with a plain loop #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bobsingor merged 1 commit into from
Nov 1, 2026
Merged

Check rich fallback coverage with a plain loop #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions core/fpdfdoc/cpdf_annotfontmap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -926,11 +926,16 @@ int CPDF_AnnotFontMap::FindRichFallback(WideStringView grapheme,
}
for (CFX_FontRegistry::FontId font_id : CFX_FontRegistry::GetFallbackOrder(
weight, italic, /*for_authoring=*/true)) {
const bool covers = std::ranges::all_of(
pdfium::CodePointView(grapheme), [font_id](char32_t cp) {
return !NeedsGlyph(cp) || CFX_FontRegistry::SupportsUnicode(
font_id, static_cast<uint32_t>(cp));
});
// A plain loop: on a 16-bit wchar_t platform CodePointView is no range a
// std::ranges algorithm accepts, only something to iterate.
bool covers = true;
for (char32_t cp : pdfium::CodePointView(grapheme)) {
if (NeedsGlyph(cp) && !CFX_FontRegistry::SupportsUnicode(
font_id, static_cast<uint32_t>(cp))) {
covers = false;
break;
}
}
if (covers) {
return EntryForRegisteredFont(font_id);
}
Expand Down