Skip to content

fix: forward useServiceUrl in the shorter TryAddAwsService overload #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Blind-Striker merged 1 commit into from
Oct 23, 2026
+25 −1
Merged

fix: forward useServiceUrl in the shorter TryAddAwsService overload #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/LocalStack.Client.Extensions/ServiceCollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ public static IServiceCollection AddAWSServiceLocalStack<TService>(this IService
public static IServiceCollection TryAddAwsService<TService>(this IServiceCollection collection, ServiceLifetime lifetime = ServiceLifetime.Singleton,
bool useServiceUrl = false) where TService : IAmazonService
{
return TryAddAwsService<TService>(collection, null, lifetime);
return TryAddAwsService<TService>(collection, null, lifetime, useServiceUrl);
}

/// <summary>
Expand Down
24 changes: 24 additions & 0 deletions tests/LocalStack.Client.Extensions.Tests/ServiceCollectionExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,30 @@ public void
}
}

[Theory, InlineData(true), InlineData(false)]
public void TryAddAwsService_Should_Forward_UseServiceUrl_To_Session(bool useServiceUrl)
{
var configurationValue = new Dictionary<string, string?>(StringComparer.Ordinal) { { "LocalStack:UseLocalStack", "true" } };
IConfiguration configuration = new ConfigurationBuilder().AddInMemoryCollection(configurationValue).Build();

var mockSession = new Mock<ISession>(MockBehavior.Strict);
ISession mockSessionObject = mockSession.Object;
mockSession.Setup(session => session.CreateClientByInterface<IMockAmazonService>(It.IsAny<bool>()))
.Returns(() => new MockAmazonServiceClient("tsada", "sadasdas", "sadasda", MockClientConfig.CreateDefaultMockClientConfig()));

IServiceCollection serviceCollection = new ServiceCollection();
serviceCollection.AddLocalStack(configuration)
.Replace(ServiceDescriptor.Singleton(_ => mockSessionObject));
serviceCollection.TryAddAwsService<IMockAmazonService>(useServiceUrl: useServiceUrl);

using ServiceProvider provider = serviceCollection.BuildServiceProvider();

var mockAmazonService = provider.GetRequiredService<IMockAmazonService>();

Assert.NotNull(mockAmazonService);
mockSession.Verify(session => session.CreateClientByInterface<IMockAmazonService>(It.Is<bool>(b => b == useServiceUrl)), Times.Once);
}

[Theory, InlineData(false, false, false), InlineData(false, false, true), InlineData(true, false, false), InlineData(true, false, true),
InlineData(false, true, false), InlineData(false, true, true), InlineData(true, true, false), InlineData(true, true, true)]
public void GetRequiredService_Should_Use_Suitable_ClientFactory_To_Create_AwsService_By_UseLocalStack_Value(
Expand Down
Loading