Repository navigation
fix: forward useServiceUrl in the shorter TryAddAwsService overload - #66
Merged
Blind-Striker merged 1 commit intoOct 23, 2026
Conversation
Blind-Striker
added this pull request to stack #69
October 23, 2026 11:12
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Blind-Striker
force-pushed
the
aot/issue-63-tryadd-use-service-url
branch
from
October 23, 2026 11:23
fae374b to
a297f33
Compare
Blind-Striker
force-pushed
the
aot/issue-63-tryadd-use-service-url
branch
from
October 23, 2026 13:33
a297f33 to
3cf4f81
Compare
This was referenced Oct 23, 2026
TryAddAwsService<TService>(lifetime, useServiceUrl) called the AWSOptions overload without useServiceUrl, so the flag was always false. Forward it like every other registration overload does. Fixes #63
Blind-Striker
force-pushed
the
aot/issue-63-tryadd-use-service-url
branch
from
October 23, 2026 20:24
3cf4f81 to
0c421fe
Compare
This was referenced Oct 23, 2026
Blind-Striker
marked this pull request as ready for review
October 23, 2026 21:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (review bottom-up, merge as one stack): #62 base, #66 the #63 fix, #67 Native AOT test lane, #68 static-factory generic path, #70 slim generator, #71 public docs, #72 internal docs and 3.0.0, #73 reflection-free test, #74 package consumer in CI, #75 convention clean-up, #76 service catalog refresh.
Goal of the stack: 3.0.0, where existing consumers upgrade without code changes, both packages support Native AOT on net10.0/net11.0, and the libraries use no runtime reflection for types the compiler can see (a JIT-only fallback covers the rest).
This PR
Fixes #63:
TryAddAwsService<TService>(lifetime, useServiceUrl)droppeduseServiceUrl. It now forwards it like every other overload. This is a behaviour change for callers who passedtrue(they now getServiceURL), recorded in the changelog.Verification
New theory
TryAddAwsService_Should_Forward_UseServiceUrl_To_Session: thetruerow fails on the base and passes after. Extensions 62 x2, Core 100 x3.