Repository navigation
Convention clean-up: Should test names and shared framework properties - #75
Merged
Merged
Conversation
Blind-Striker
added this pull request to stack #69
October 23, 2026 20:24
This was referenced Oct 23, 2026
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Blind-Striker
force-pushed
the
aot/convention-cleanup
branch
from
October 23, 2026 21:13
be05d72 to
3866954
Compare
Blind-Striker
marked this pull request as ready for review
October 23, 2026 21:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack (review bottom-up, merge as one stack): #62 base, #66 the #63 fix, #67 Native AOT test lane, #68 static-factory generic path, #70 slim generator, #71 public docs, #72 internal docs and 3.0.0, #73 reflection-free test, #74 package consumer in CI, #75 convention clean-up, #76 service catalog refresh.
Goal of the stack: 3.0.0, where existing consumers upgrade without code changes, both packages support Native AOT on net10.0/net11.0, and the libraries use no runtime reflection for types the compiler can see (a JIT-only fallback covers the rest).
This PR
Convention clean-up across the stack, from a review of
master..HEADagainst the repository's conventions. No behaviour change.Multi_Region_Tests_Async, is nowSnsService_Should_Create_A_Sns_Topic_In_The_Configured_Region_Async. The review checked all 386[Fact]/[Theory]methods.Directory.Packages.propscompares with$(LocalStackNetFrameworkTargetFramework).BuildContextnames its MSBuild property keys once.LocalStackAnalyzerTargetFramework(netstandard2.0, because Roslyn loads generators only from netstandard2.0). The generator project and Core's pack path for the generator use it. It is kept separate fromLocalStackNetStandardTargetFrameworkbecause the two have different owners.S3ForcePathStylecompares withAwsServiceEndpointMetadata.S3.ServiceIdinstead of"S3".SessionReflectionTestscallbacks are formatted one statement per line.Review findings not taken:
tests/Directory.Build.targetskeeps itsIsTargetFrameworkCompatiblecheck.IsLocalStackModernTargetis computed at props time, so it is empty for single-target projects and would drop the generator reference there.PreBuildREADME/license targets already existed on master. The twoIsAotCompatible/package-validation lines already read shared properties, and moving them to.targetswould bring an evaluation-order risk.Verification
Core, Extensions, Integration, Generator and the Cake
teststarget are green; the Native AOT lane (net10.0) is green; the packed Core still contains the generator undertools/. Stack-level gate: #76.