Repository navigation
fix: use get_origin() for typing.GenericAlias detection - #3746
Jihaochang1 wants to merge 2 commits into
Conversation
Fixes modelcontextprotocol#3745 by checking the origin of type expressions instead of their class type. typing.Dict[str, Any] is a typing._GenericAlias, not a types.GenericAlias, so the previous check failed to match it. This ensures consistent behavior between typing.Dict and dict annotations, preventing silent schema changes when Ruff UP006 rewrites old-style annotations to modern syntax.
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3745. If a maintainer assigns you to #3745, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Summary
Fixes #3745 by checking the origin of type expressions instead of their class type.
Problem
typing.Dict[str, Any]is atyping._GenericAlias, not atypes.GenericAliasisinstance(type_expr, GenericAlias)failed to match itFix
Changed from:
to:
This properly handles both
typing.Dictanddictannotations consistently.Impact
Closes #3745