Skip to content

fix: use get_origin() for typing.GenericAlias detection #3746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Jihaochang1 wants to merge 2 commits into from
+3 −1
Closed

fix: use get_origin() for typing.GenericAlias detection #3746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b68722b
fix: handle HEAD on SSE endpoint to prevent connection leaks (fixes #…
Jihaochang1 Oct 23, 2026
a466c65
fix: use get_origin() for typing.GenericAlias detection
Jihaochang1 Oct 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mcp/server/mcpserver/utilities/func_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,7 +500,7 @@ def _create_output_model(original_annotation: Any, type_expr: Any, func_name: st
wrap_output = True

# Handle GenericAlias types (list[str], dict[str, int], Union[str, int], etc.)
elif isinstance(type_expr, GenericAlias):
elif get_origin(type_expr) is not None:
origin = get_origin(type_expr)

if origin is dict:
Expand Down
2 changes: 2 additions & 0 deletions src/mcp/server/sse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@

# Define handler functions
async def handle_sse(request):
if scope["method"] == "HEAD":
return Response(media_type="text/event-stream", headers={"Cache-Control": "no-store"})
async with sse.connect_sse(
request.scope, request.receive, request._send
) as streams:
Expand Down
Loading