Skip to content

[Brook] Added the Redis and memory stream store plugins. - #153

Closed
moetemp wants to merge 6 commits into
moe/brook/v2/p2d-topics-refsfrom
moe/brook/v2/p2e-provider-plugin
Closed

moetemp wants to merge 6 commits into
moe/brook/v2/p2d-topics-refsfrom
moe/brook/v2/p2e-provider-plugin

Conversation

@moetemp

@moetemp moetemp commented Oct 13, 2026

Copy link
Copy Markdown
Owner

What changed?

This PR adds RedisStreams and MemoryStreams, the client plugins that name the store Core runs.

  • StreamStorePlugin is a SimplePlugin that connects the store in connect_service_client. The client's handles and the Activities of every Worker built from it use that store.
  • RedisStreams takes URLs and Core's settings. TLS comes from a rediss:// URL and checks the server against the system roots only. MemoryStreams() is for tests.
  • A store on a Worker alone raises ValueError, and so does a second store on one client or a second connection on one store.
  • delete_workflow_streams(namespace, workflow_id) goes through Core's DeleteOwner.

Why?

Core runs the store, so the provider classes become configuration (DD-6, DD-90). Core checks a stream's owner over the connection that connected the store, so the store comes from the client.

How did you test it?

Link to a test plan if any -

  • Unit Tests
  • Staging
  • End to End Tests

tests/contrib/streams/test_store_plugin.py runs on the dev server.

@moetemp moetemp added the skip-changelog Changelog entry rides another PR label Oct 13, 2026
@moetemp

moetemp commented Oct 16, 2026

Copy link
Copy Markdown
Owner Author

Combined into #240.

@moetemp moetemp closed this Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog Changelog entry rides another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant